Skip to content

Conversation

@eriawan
Copy link
Member

@eriawan eriawan commented Oct 22, 2022

Summary

Fixes #7515 by updating File.ReadAllText supported encoding in the remarks.

I have copied the text from StreamReader as is.

cc @jozkee @adamsitnik

@eriawan eriawan requested a review from a team as a code owner October 22, 2022 20:53
@ghost ghost added community-contribution Indicates that the PR has been added by a community member area-System.IO labels Oct 22, 2022
@ghost
Copy link

ghost commented Oct 22, 2022

Tagging subscribers to this area: @dotnet/area-system-io
See info in area-owners.md if you want to be subscribed.

Issue Details

Summary

Fixes #7515 by updating File.ReadAllText supported encoding in the remarks.

I have copied the text from StreamReader as is.

cc @jozkee @adamsitnik

Author: eriawan
Assignees: -
Labels:

area-System.IO, community-contribution

Milestone: -

@opbld34
Copy link

opbld34 commented Oct 22, 2022

Learn Build status updates of commit 8c65833:

✅ Validation status: passed

File Status Preview URL Details
xml/System.IO/File.xml ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

Copy link
Member

@adamsitnik adamsitnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @eriawan !

@adamsitnik adamsitnik merged commit 22f5509 into dotnet:main Oct 24, 2022
@eriawan eriawan deleted the update-system_io_file-ReadAllText branch October 24, 2022 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-System.IO community-contribution Indicates that the PR has been added by a community member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

File.ReadAllText() also detects UTF-16

3 participants