Skip to content

Conversation

@crpz1
Copy link
Contributor

@crpz1 crpz1 commented Oct 24, 2022

Summary

This pull request removes the trailing \ from the list of sections as the last one was visible in the final page.
All of them were removed to be more in line with other documents such as System.Security.SecureString with similar table of content like sections.

@crpz1 crpz1 requested a review from a team as a code owner October 24, 2022 15:30
@ghost ghost added community-contribution Indicates that the PR has been added by a community member area-System.Globalization labels Oct 24, 2022
@ghost
Copy link

ghost commented Oct 24, 2022

Tagging subscribers to this area: @dotnet/area-system-globalization
See info in area-owners.md if you want to be subscribed.

Issue Details

Summary

This pull request removes the trailing \ from the list of sections as the last one was visible in the final page.
All of them were removed to be more in line with other documents such as System.Security.SecureString with similar table of content like sections.

Author: crpz1
Assignees: -
Labels:

area-System.Globalization, community-contribution

Milestone: -

@tarekgh
Copy link
Member

tarekgh commented Oct 24, 2022

@crpz1 the backslash is not showing except in the last line.

https://learn.microsoft.com/en-us/dotnet/api/system.globalization.cultureinfo?view=net-7.0
image

@opbld30
Copy link

opbld30 commented Oct 24, 2022

Learn Build status updates of commit 9e22687:

✅ Validation status: passed

File Status Preview URL Details
xml/System.Globalization/CultureInfo.xml ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@gewarren
Copy link
Contributor

This is what happens without the backslashes (hard line breaks) - so can you just remove the final one?

image

@tarekgh
Copy link
Member

tarekgh commented Oct 24, 2022

@crpz1 could you please revert this change and only keep removing the slash in the last line?

@tarekgh tarekgh added the needs-author-action An issue or pull request that requires more info or actions from the author. label Oct 24, 2022
@ghost ghost removed the needs-author-action An issue or pull request that requires more info or actions from the author. label Oct 24, 2022
@crpz1
Copy link
Contributor Author

crpz1 commented Oct 24, 2022

I see, for future reference, how would one build this to preview changes?

@gewarren
Copy link
Contributor

I see, for future reference, how would one build this to preview changes?

A preview is generated automatically but unfortunately it's only visible internally at Microsoft.

@gewarren gewarren enabled auto-merge (squash) October 24, 2022 17:07
@opbld33
Copy link

opbld33 commented Oct 24, 2022

Learn Build status updates of commit 1223908:

✅ Validation status: passed

File Status Preview URL Details
xml/System.Globalization/CultureInfo.xml ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@gewarren gewarren merged commit 6c5eb53 into dotnet:main Oct 24, 2022
@crpz1 crpz1 deleted the crpz1-patch-1 branch October 24, 2022 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-System.Globalization community-contribution Indicates that the PR has been added by a community member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants