Skip to content

Conversation

@gewarren
Copy link
Contributor

Fixes #8090.

VSC-Service-Account and others added 2 commits November 10, 2022 02:55
@gewarren gewarren requested review from a team as code owners November 10, 2022 04:03
@ghost ghost assigned gewarren Nov 10, 2022
@ghost ghost added the area-System.Security Issues related to security practices for .NET developers. label Nov 10, 2022
@ghost
Copy link

ghost commented Nov 10, 2022

Tagging subscribers to this area: @dotnet/area-system-security, @vcsjones
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #8090.

Author: gewarren
Assignees: gewarren
Labels:

area-System.Security

Milestone: -

@gewarren gewarren requested review from a team and removed request for a team November 10, 2022 04:16
@gewarren gewarren added area-System.IO and removed area-System.Security Issues related to security practices for .NET developers. labels Nov 10, 2022
@ghost
Copy link

ghost commented Nov 10, 2022

Tagging subscribers to this area: @dotnet/area-system-io
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #8090.

Author: gewarren
Assignees: gewarren
Labels:

area-System.IO

Milestone: -

@opbld32

This comment was marked as outdated.

@adamsitnik adamsitnik requested a review from a team November 10, 2022 13:01
@adamsitnik adamsitnik added area-System.Security Issues related to security practices for .NET developers. and removed area-System.IO labels Nov 10, 2022
@ghost
Copy link

ghost commented Nov 10, 2022

Tagging subscribers to this area: @dotnet/area-system-security, @vcsjones
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #8090.

Author: gewarren
Assignees: gewarren
Labels:

area-System.Security

Milestone: -

Copy link
Member

@bartonjs bartonjs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why the structural addition of System.IO.Hashing is intermixed with some content cleanup in System.Net; but other than one change I disagree with to the System.Net documentation (I believe "match the title of the destination page of a link" wins out over house-style), LGTM.

Co-authored-by: Jeremy Barton <jbarton@microsoft.com>
@gewarren
Copy link
Contributor Author

Not sure why the structural addition of System.IO.Hashing is intermixed with some content cleanup in System.Net; but other than one change I disagree with to the System.Net documentation (I believe "match the title of the destination page of a link" wins out over house-style), LGTM.

The CI job runs over all the assemblies, not just the new one. And I added some manual touch-ups to a file that was changed anyway since there were some bad grammar errors.

@gewarren gewarren enabled auto-merge November 10, 2022 19:11
@gewarren gewarren disabled auto-merge November 10, 2022 19:11
@gewarren gewarren enabled auto-merge (squash) November 10, 2022 19:12
@opbld32
Copy link

opbld32 commented Nov 10, 2022

Learn Build status updates of commit 07fecdc:

✅ Validation status: passed

File Status Preview URL Details
xml/FrameworksIndex/dotnet-plat-ext-6.0.xml ✅Succeeded
xml/System.IO.Hashing/Crc32.xml ✅Succeeded View
xml/System.IO.Hashing/Crc64.xml ✅Succeeded View
xml/System.IO.Hashing/NonCryptographicHashAlgorithm.xml ✅Succeeded View
xml/System.IO.Hashing/XxHash32.xml ✅Succeeded View
xml/System.IO.Hashing/XxHash64.xml ✅Succeeded View
xml/System.Net.Sockets/Socket.xml ✅Succeeded View
xml/System.Net.Sockets/SocketTaskExtensions.xml ✅Succeeded View
xml/System.Net.Sockets/TcpClient.xml ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@gewarren gewarren merged commit 0f686c6 into main Nov 10, 2022
@gewarren gewarren deleted the net6-update branch November 10, 2022 19:38
@jeffhandley jeffhandley removed the area-System.Security Issues related to security practices for .NET developers. label Nov 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Missing System.IO.Hashing docs on website

7 participants