-
Notifications
You must be signed in to change notification settings - Fork 1.7k
CI Update - Add System.IO.Hashing to .NET 6 #8619
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Build.Reason:Manual by Genevieve Warren Build.Url:https://apidrop.visualstudio.com/Content%20CI/_build/results?buildId=330679&view=results source_repo.branch:hasing source_repo.url:https://apidrop.visualstudio.com/_git/binaries
|
Tagging subscribers to this area: @dotnet/area-system-security, @vcsjones Issue DetailsFixes #8090.
|
|
Tagging subscribers to this area: @dotnet/area-system-io |
This comment was marked as outdated.
This comment was marked as outdated.
|
Tagging subscribers to this area: @dotnet/area-system-security, @vcsjones Issue DetailsFixes #8090.
|
bartonjs
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure why the structural addition of System.IO.Hashing is intermixed with some content cleanup in System.Net; but other than one change I disagree with to the System.Net documentation (I believe "match the title of the destination page of a link" wins out over house-style), LGTM.
Co-authored-by: Jeremy Barton <jbarton@microsoft.com>
The CI job runs over all the assemblies, not just the new one. And I added some manual touch-ups to a file that was changed anyway since there were some bad grammar errors. |
|
Learn Build status updates of commit 07fecdc: ✅ Validation status: passed
For more details, please refer to the build report. Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report. For any questions, please:
|
Fixes #8090.