Skip to content

Conversation

@OwnageIsMagic
Copy link

@ghost ghost added community-contribution Indicates that the PR has been added by a community member area-System.Data Data APIs (ADO.NET, XML, etc). labels Sep 25, 2023
@ghost
Copy link

ghost commented Sep 25, 2023

Tagging subscribers to this area: @roji, @ajcvickers
See info in area-owners.md if you want to be subscribed.

Issue Details

See net402 release notes https://support.microsoft.com/en-us/topic/update-4-0-2-for-microsoft-net-framework-4-runtime-update-8d0f21a2-2459-c5dd-8a23-49518a89cafc#ID0EDBBHBD

Author: OwnageIsMagic
Assignees: -
Labels:

area-System.Data, community-contribution

Milestone: -

@learn-build-service-prod
Copy link

Learn Build status updates of commit afd3e4e:

✅ Validation status: passed

File Status Preview URL Details
xml/System.Data.Common/DbProviderFactories.xml ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

Copy link
Member

@roji roji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.NET Framework 4.0.2 is out of support, I don't think we should be adding out-of-support patch versions to this list.

@OwnageIsMagic
Copy link
Author

OwnageIsMagic commented Sep 26, 2023

But it doesn't hurt anyone and makes the world a better place. If you don't like 4.0.2 we can lie a little and say 4.0.3 which have official PCL and NuGet TFM.

@roji
Copy link
Member

roji commented Sep 26, 2023

@OwnageIsMagic adding each and every supported patch version - including unsupported ones - makes the list harder to read for everyone. We'd also need to be consistent, checking and adding all other patch versions to this list (otherwise why specifically 4.0.2), and do the same for other APIs. That simply doesn't make sense.

@OwnageIsMagic
Copy link
Author

@roji hey, look at the current content. It literally names every minor patch of net framework since 4.5
4.5, 4.5.1, 4.5.2, 4.6, 4.6.1, 4.6.2, 4.7, 4.7.1, 4.7.2, 4.8, 4.8.1
4.0.2 here is special since it's minimal required.
But you are partially right: I should add both 4.0.2 and 4.0.3.
Btw this is the only API added in 4.0.2
4.0.1 added Windows Workflow Foundation StateMachine
4.0.3 GCLatencyMode.SustainedLowLatency and SqlConnection.ClientConnectionId

I can add them to this PR too, so it will be completely covered.

@roji
Copy link
Member

roji commented Sep 26, 2023

I'll leave someone from the .NET API docs team to answer about the policy here (I'm just a dev working on related APIs and don't make these decisions). But my opinion is that we shouldn't be adding all unsupported patch versions everywhere in all docs. It's both a waste of time and makes the docs harder to read. If anything I'd consider removing all unsupported TFMs.

@MSDN-WhiteKnight
Copy link
Contributor

This XML metadata actually should not be modified at all, it is automatically generated by CI. Only the contents of Docs tag are manually editable in this repository.

4.0.2 patch is probably not included here because CI does not pick reference assemblies for that exact version. Just adding it here might be not enough to display it on docs website without explicitly enabling it in some config.

@gewarren gewarren closed this Sep 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-System.Data Data APIs (ADO.NET, XML, etc). community-contribution Indicates that the PR has been added by a community member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants