-
Notifications
You must be signed in to change notification settings - Fork 1.7k
DbProviderFactories.GetFactory supported on net402 #9323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Tagging subscribers to this area: @roji, @ajcvickers Issue DetailsSee net402 release notes https://support.microsoft.com/en-us/topic/update-4-0-2-for-microsoft-net-framework-4-runtime-update-8d0f21a2-2459-c5dd-8a23-49518a89cafc#ID0EDBBHBD
|
|
Learn Build status updates of commit afd3e4e: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
roji
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.NET Framework 4.0.2 is out of support, I don't think we should be adding out-of-support patch versions to this list.
|
@OwnageIsMagic adding each and every supported patch version - including unsupported ones - makes the list harder to read for everyone. We'd also need to be consistent, checking and adding all other patch versions to this list (otherwise why specifically 4.0.2), and do the same for other APIs. That simply doesn't make sense. |
|
@roji hey, look at the current content. It literally names every minor patch of net framework since 4.5 I can add them to this PR too, so it will be completely covered. |
|
I'll leave someone from the .NET API docs team to answer about the policy here (I'm just a dev working on related APIs and don't make these decisions). But my opinion is that we shouldn't be adding all unsupported patch versions everywhere in all docs. It's both a waste of time and makes the docs harder to read. If anything I'd consider removing all unsupported TFMs. |
|
This XML metadata actually should not be modified at all, it is automatically generated by CI. Only the contents of 4.0.2 patch is probably not included here because CI does not pick reference assemblies for that exact version. Just adding it here might be not enough to display it on docs website without explicitly enabling it in some config. |
See net402 release notes https://support.microsoft.com/en-us/topic/update-4-0-2-for-microsoft-net-framework-4-runtime-update-8d0f21a2-2459-c5dd-8a23-49518a89cafc#ID0EDBBHBD