Skip to content

Fix SHA384/512 examples #9828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
gewarren merged 3 commits into from
Apr 19, 2024
Merged

Fix SHA384/512 examples #9828

gewarren merged 3 commits into from
Apr 19, 2024

Conversation

@vcsjones
Copy link
Member

@vcsjones vcsjones commented Apr 19, 2024

Summary

  1. The examples for the algorithms that are not specifically for the Managed variants now use the factory method.
  2. The examples were updated to demonstrate proper resource cleanup.

Fixes #9826

@vcsjones vcsjones requested a review from a team as a code owner April 19, 2024 10:39
@ghost ghost added the area-System.Security Issues related to security practices for .NET developers. label Apr 19, 2024
@dotnet-policy-service
Copy link
Contributor

dotnet-policy-service bot commented Apr 19, 2024

Tagging subscribers to this area: @dotnet/area-system-security, @vcsjones

@learn-build-service-prod
Copy link

learn-build-service-prod bot commented Apr 19, 2024

Learn Build status updates of commit df511c2:

✅ Validation status: passed

File Status Preview URL Details
snippets/csharp/System.Security.Cryptography/SHA384/Overview/source.cs ✅Succeeded View
snippets/csharp/System.Security.Cryptography/SHA384Managed/Overview/source.cs ✅Succeeded View
snippets/csharp/System.Security.Cryptography/SHA512/Overview/source.cs ✅Succeeded View
snippets/csharp/System.Security.Cryptography/SHA512Managed/Overview/source.cs ✅Succeeded View
snippets/visualbasic/VS_Snippets_CLR_Classic/classic SHA384 Example/VB/source.vb ✅Succeeded View
snippets/visualbasic/VS_Snippets_CLR_Classic/classic SHA384Managed Example/VB/source.vb ✅Succeeded View
snippets/visualbasic/VS_Snippets_CLR_Classic/classic SHA512 Example/VB/source.vb ✅Succeeded View
snippets/visualbasic/VS_Snippets_CLR_Classic/classic SHA512Managed Example/VB/source.vb ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

adamsitnik
adamsitnik approved these changes Apr 19, 2024
View reviewed changes
Copy link
Member

@adamsitnik adamsitnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you very much for fixing the docs @vcsjones !

@learn-build-service-prod
Copy link

learn-build-service-prod bot commented Apr 19, 2024

Learn Build status updates of commit 8dc1ef0:

✅ Validation status: passed

File Status Preview URL Details
snippets/csharp/System.Security.Cryptography/SHA384/Overview/source.cs ✅Succeeded View
snippets/csharp/System.Security.Cryptography/SHA384Managed/Overview/source.cs ✅Succeeded View
snippets/csharp/System.Security.Cryptography/SHA512/Overview/source.cs ✅Succeeded View
snippets/csharp/System.Security.Cryptography/SHA512Managed/Overview/source.cs ✅Succeeded View
snippets/visualbasic/VS_Snippets_CLR_Classic/classic SHA384 Example/VB/source.vb ✅Succeeded View
snippets/visualbasic/VS_Snippets_CLR_Classic/classic SHA384 Example/VB/vb.vbproj ✅Succeeded
snippets/visualbasic/VS_Snippets_CLR_Classic/classic SHA384Managed Example/VB/source.vb ✅Succeeded View
snippets/visualbasic/VS_Snippets_CLR_Classic/classic SHA384Managed Example/VB/vb.vbproj ✅Succeeded
snippets/visualbasic/VS_Snippets_CLR_Classic/classic SHA512 Example/VB/source.vb ✅Succeeded View
snippets/visualbasic/VS_Snippets_CLR_Classic/classic SHA512 Example/VB/vb.vbproj ✅Succeeded
snippets/visualbasic/VS_Snippets_CLR_Classic/classic SHA512Managed Example/VB/source.vb ✅Succeeded View
snippets/visualbasic/VS_Snippets_CLR_Classic/classic SHA512Managed Example/VB/vb.vbproj ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

gewarren
gewarren approved these changes Apr 19, 2024
View reviewed changes
Copy link
Contributor

@gewarren gewarren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @vcsjones

@gewarren gewarren merged commit 7cb362d into dotnet:main Apr 19, 2024
@vcsjones vcsjones deleted the sha384-512-examples branch April 19, 2024 16:49
@learn-build-service-prod
Copy link

learn-build-service-prod bot commented Apr 19, 2024

Learn Build status updates of commit 420133b:

✅ Validation status: passed

File Status Preview URL Details
snippets/csharp/System.Security.Cryptography/SHA384/Overview/source.cs ✅Succeeded View
snippets/csharp/System.Security.Cryptography/SHA384Managed/Overview/source.cs ✅Succeeded View
snippets/csharp/System.Security.Cryptography/SHA512/Overview/source.cs ✅Succeeded View
snippets/csharp/System.Security.Cryptography/SHA512Managed/Overview/source.cs ✅Succeeded View
snippets/visualbasic/VS_Snippets_CLR_Classic/classic SHA384 Example/VB/source.vb ✅Succeeded View
snippets/visualbasic/VS_Snippets_CLR_Classic/classic SHA384 Example/VB/vb.vbproj ✅Succeeded
snippets/visualbasic/VS_Snippets_CLR_Classic/classic SHA384Managed Example/VB/source.vb ✅Succeeded View
snippets/visualbasic/VS_Snippets_CLR_Classic/classic SHA384Managed Example/VB/vb.vbproj ✅Succeeded
snippets/visualbasic/VS_Snippets_CLR_Classic/classic SHA512 Example/VB/source.vb ✅Succeeded View
snippets/visualbasic/VS_Snippets_CLR_Classic/classic SHA512 Example/VB/vb.vbproj ✅Succeeded
snippets/visualbasic/VS_Snippets_CLR_Classic/classic SHA512Managed Example/VB/source.vb ✅Succeeded View
snippets/visualbasic/VS_Snippets_CLR_Classic/classic SHA512Managed Example/VB/vb.vbproj ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adamsitnik adamsitnik adamsitnik approved these changes

@gewarren gewarren gewarren approved these changes

Assignees

@vcsjones vcsjones

Labels

area-System.Security Issues related to security practices for .NET developers.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

SHA512 and the likes' examples are obsolete

3 participants

@vcsjones @adamsitnik @gewarren