Skip to content

chore: suppress linter warnings in unit tests and add preview feature annotations to examples #990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 20, 2025
Merged

chore: suppress linter warnings in unit tests and add preview feature annotations to examples #990

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3acece8
chore: suppress warnings and add preview feature annotations in tests…
kimpenhaus Nov 17, 2025
2690636
chore: suppress CA2252 warning in KubernetesClientAsync test class
kimpenhaus Nov 17, 2025
3fa2157
chore: restore correct annotation order and suppress CA2252 warning i…
kimpenhaus Nov 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions examples/ConversionWebhookOperator/Webhooks/TestConversionWebhook.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,15 @@
// The .NET Foundation licenses this file to you under the Apache 2.0 License.
// See the LICENSE file in the project root for more information.

using System.Runtime.Versioning;

using ConversionWebhookOperator.Entities;

using KubeOps.Operator.Web.Webhooks.Conversion;

namespace ConversionWebhookOperator.Webhooks;

[RequiresPreviewFeatures]
[ConversionWebhook(typeof(V3TestEntity))]
public class TestConversionWebhook : ConversionWebhook<V3TestEntity>
{
Expand Down
2 changes: 2 additions & 0 deletions test/KubeOps.Abstractions.Test/Entities/JsonPatchExtensions.Test.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@

namespace KubeOps.Abstractions.Test.Entities;

#pragma warning disable CA2252 // Opt in to preview features before using them

public class JsonPatchExtensionsTest
{
[Fact]
Expand Down
2 changes: 2 additions & 0 deletions test/KubeOps.KubernetesClient.Test/KubernetesClient.Test.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@

namespace KubeOps.KubernetesClient.Test;

#pragma warning disable CA2252 // Opt in to preview features before using them

public sealed class KubernetesClientTest : IntegrationTestBase, IDisposable
{
private readonly IKubernetesClient _client =
Expand Down
2 changes: 2 additions & 0 deletions test/KubeOps.KubernetesClient.Test/KubernetesClientAsync.Test.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@

namespace KubeOps.KubernetesClient.Test;

#pragma warning disable CA2252 // Opt in to preview features before using them

public sealed class KubernetesClientAsyncTest : IntegrationTestBase, IDisposable
{
private readonly IKubernetesClient _client =
Expand Down
6 changes: 3 additions & 3 deletions test/KubeOps.Operator.Web.Test/Builder/OperatorBuilderExtensions.Test.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,6 @@
// The .NET Foundation licenses this file to you under the Apache 2.0 License.
// See the LICENSE file in the project root for more information.

using System.Runtime.Versioning;

using FluentAssertions;

using KubeOps.Abstractions.Builder;
Expand All @@ -18,7 +16,9 @@
using Microsoft.Extensions.Hosting;

namespace KubeOps.Operator.Web.Test.Builder;
[RequiresPreviewFeatures]

#pragma warning disable CA2252 // Opt in to preview features before using them

public class OperatorBuilderExtensionsTest : IDisposable
{
private readonly IOperatorBuilder _builder = new OperatorBuilder(new ServiceCollection(), new());
Expand Down