Enable error logging in source-build and other tests #3207
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ellahathaway
approved these changes
Nov 3, 2025
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a conditional logic error in the test utility's process execution error handling. The condition was incorrectly checking if the error string was null or whitespace before logging it, when it should have been checking if it was NOT null or whitespace.
Key Changes:
- Fixed inverted conditional logic for error message output in
ExecuteProcessmethod
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
mthalman
approved these changes
Nov 3, 2025
Member
|
/backport to release/10.0.1xx |
Contributor
|
Started backporting to |
Member
|
/backport to release/10.0.2xx |
Contributor
|
Started backporting to |
This was referenced Dec 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the issue with logging of process errors.
ExecuteHelperis used by source-build and other tests.For some reason the condition was incorrect, so errors were never logged. Found this by accident while investigating #3144