Adding EntityFrameworkCore.SqlServer 9.0.1 breaks System.Windows.Forms

[andrewwong0893]

Bug description

I am upgrading from dotnet 8 to dotnet 9 on a WPF application.

Updating the framework works perfectly fine, but when it comes to updating the nuget package, all instances of System.Windows.Forms suddenly stopped working. MessageBoxButtons, FolderBrowserDialog, Cursor.Position no longer works.
When I revert the EF package back to version 8, the problem goes away.

Testing with EFCore.Sqlite works perfectly fine

Your code

var currentScreen = Screen.FromPoint(System.Windows.Forms.Cursor.Position);

// -------------------------------------------------------------------------------------

var filePath = string.Empty;
var dialog = new FolderBrowserDialog();

if (dialog.ShowDialog() == DialogResult.OK)
{
    filePath = dialog.SelectedPath;
}

//-----------------------------------------------------------------------------
var result = MessageBox.Show("Message",
                             "Title",
                             MessageBoxButtons.RetryCancel,
                             MessageBoxIcon.Exclamation,
                             MessageBoxDefaultButton.Button1);

if (result != DialogResult.Retry)
{
    //...
}

Stack traces

Verbose output

EF Core version

9.0.1

Database provider

Microsoft.EntityFrameworkCore.SqlServer

Target framework

.NET 9.0

Operating system

Windows 11

IDE

VS Pro 17.12.3

[andrewwong0893]

Just had a played around with the nuget versions.
The breaks happened from 8.0.10 to 8.0.11

[roji]

Testing with EFCore.Sqlite works perfectly fine

Are you saying that the EF Core Sqlite provider works well in 8.0.11 and 9.0.1, and that there's a problem only when using the SQL Server provider (or some other provider)?

We didn't do any updates between 8.0.10 to 8.0.11 (or between 9.0.0 to 9.0.1) that look like they could be related, and definitely nothing in the SQL Server provider specifically (since you're saying the SQLite provider works). We most likely bumped some version dependencies, but if that's the source of the problem, that wouldn't be in EF.

Can you please put together a minimal, runnable code sample that works on 8.0.10 but not on 8.0.11? The above is only a partial snippet.

[ErikEJ]

Microsoft.Data.SqlClient was bumped from 5.1.5 to 5.1.6 in 8.0.11

[ErikEJ]

Release notes for one of the SqlClient updated dependencies here, some mention of something WinForms: https://github.com/AzureAD/microsoft-authentication-library-for-dotnet/releases/tag/4.61.0

[andrewwong0893]

I was in the middle of creating a repository to show you what I meant but I think I may have found what the problem is.

EF 8.0.10 for some reason had references to System.Windows.Forms namespace which was what was keeping my WPF project going.
In the design of my project, I did the database design first before adding WPF so when I reference my db library, it came with Forms namespace which was what I was using without knowing that WPF didn't come with the System.Windows.Forms namespace. Only System.Windows.

When updating from 8.0.10 -> 8.0.11, the namespace System.Windows.Forms got removed and since WPF never had that library in the first place, this broke my Open file dialog, save file dialog, select folder dialog, message boxes etc.

Once I migrated from System.Windows.Forms to System.Windows and Microsoft.Win32 libraries, my application started working again.