Simpler null constant checks in relational translator#37617
Merged
Conversation
Removed the IsNullSqlConstantExpression method that checks for null SQL constant expressions.
Remove IsNullSqlConstantExpression method
Member
|
@ShadyNagy rather than submitting multiple PRs (as in #37616), can you please do everything in one (this one)? |
Contributor
Author
|
@roji
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR simplifies internal null-constant checks in the relational query expression visitor by inlining pattern matching instead of using a small private helper method. The behavior is preserved while slightly reducing indirection.
Changes
RelationalSqlTranslatingExpressionVisitor, inline theIsNullSqlConstantExpressionhelper logic into the entity-equality rewrite path and delete the now-unneeded private helper.src/EFCore.Relational/Query/RelationalSqlTranslatingExpressionVisitor.StructuralEquality.csis SqlConstantExpression { Value: null }pattern matching and removes the redundant private helper.