Skip to content

Configure dependabot to use nuget.org only and add servicing-specific MSBuild/Roslyn versions#37866

Merged
AndriySvyryd merged 5 commits into
mainfrom
copilot/configure-dependabot-registry
Mar 6, 2026
Merged

Configure dependabot to use nuget.org only and add servicing-specific MSBuild/Roslyn versions#37866
AndriySvyryd merged 5 commits into
mainfrom
copilot/configure-dependabot-registry

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Mar 6, 2026

  • Configure dependabot to only use the nuget.org registry in .github/dependabot.yml
  • Split the "MSBuild and Roslyn" PropertyGroup in eng/Versions.props into two conditional groups:
    • Current group: used when ShouldUseLiveRoslyn is not true (default)
    • New group: used when ShouldUseLiveRoslyn is true (servicing AND patch >= 2), with 18.5.0 for MicrosoftBuild* and 5.5.0 for MicrosoftCodeAnalysis*
  • Extract condition into ShouldUseLiveRoslyn property to avoid duplication
  • Invert the ShouldUseLiveRoslyn condition to express the servicing case directly and use true as the sentinel value

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

…/Roslyn version groups for servicing

Co-authored-by: AndriySvyryd <6539701+AndriySvyryd@users.noreply.github.com>
Copilot AI changed the title [WIP] Configure dependabot to use nuget.org registry Configure dependabot to use nuget.org only and add servicing-specific MSBuild/Roslyn versions Mar 6, 2026
Comment thread eng/Versions.props Outdated
Co-authored-by: AndriySvyryd <6539701+AndriySvyryd@users.noreply.github.com>
Comment thread eng/Versions.props Outdated
Co-authored-by: AndriySvyryd <6539701+AndriySvyryd@users.noreply.github.com>
Comment thread eng/Versions.props Outdated
…ions

Co-authored-by: AndriySvyryd <6539701+AndriySvyryd@users.noreply.github.com>
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates repository automation/config to ensure dependency updates and build tooling versions behave correctly in servicing scenarios.

Changes:

  • Configure Dependabot NuGet updates to use only the explicitly declared nuget-org registry.
  • Introduce ShouldUseLiveRoslyn and split MSBuild/Roslyn version properties into default vs. servicing-specific groups (conditional on servicing + patch >= 2).

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
eng/Versions.props Adds ShouldUseLiveRoslyn and conditionally selects MSBuild/Roslyn package versions for servicing builds.
.github/dependabot.yml Declares a nuget-org registry and restricts the NuGet update job to that registry.

You can also share your feedback on Copilot code review. Take the survey.

@AndriySvyryd AndriySvyryd marked this pull request as ready for review March 6, 2026 04:52
@AndriySvyryd AndriySvyryd requested a review from a team as a code owner March 6, 2026 04:52
Comment thread .github/dependabot.yml
registries:
nuget-org:
type: nuget-feed
url: https://api.nuget.org/v3/index.json
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No objection but is this supposed to protect against something in particular? Like what other non-nuget.org feeds are we excluding by doing this?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's more about perf, the other feeds (containing tools and VMR-built packages) don't have any packages that dependabot should be updating.

@roji roji assigned AndriySvyryd and unassigned roji Mar 6, 2026
@AndriySvyryd AndriySvyryd merged commit 589a82f into main Mar 6, 2026
16 checks passed
@AndriySvyryd AndriySvyryd deleted the copilot/configure-dependabot-registry branch March 6, 2026 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants