Cosmos: Modernize JSON serialization - Update pipeline#38024
Draft
JoasE wants to merge 2 commits intodotnet:mainfrom
Draft
Cosmos: Modernize JSON serialization - Update pipeline#38024JoasE wants to merge 2 commits intodotnet:mainfrom
JoasE wants to merge 2 commits intodotnet:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactors
DocumentSourceto serialize to stream instead of DOM.Leverages
JsonValueReaderWriterfor serialization.For backwards compatibility:
JsonValueReaderWriter's where found to be needed.Partly removes __jObject stuff, but not fully so the binding and query pipelines still work.
TODO: Maybe string compare every test database we have with old vs new serialization?
Adds some todos aswell. Some will be picked up in next prs
Part of: #34567