Fix syntax error in API review workflow#38085
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Fixes a Python syntax error in the API review baselines GitHub Actions workflow by removing an invalid nonlocal usage in an inline Python script, while preserving the existing comment-splitting behavior for generated API diffs.
Changes:
- Removed the nested helper using
nonlocal current_body(invalid at module scope in Python) and inlined the comment-body accumulation logic. - Initialized and handled
sectionexplicitly per baseline file, skipping empty sections before appending to the comment body. - Kept the max-length splitting behavior for multi-comment posting, implemented inline.
AndriySvyryd
force-pushed
the
ApiWorkflowFix4
branch
from
ca0bc83 to
0c2d11c
Compare
roji
approved these changes
Apr 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
😠