Merged
Conversation
AndriySvyryd
force-pushed
the
RefactorCommandBatchPreparer
branch
from
f21e654 to
eb6fe8e
Compare
There was a problem hiding this comment.
Pull request overview
This PR refactors how CommandBatchPreparer builds foreign-key dependency ordering between modification commands by extracting the predecessor collection and edge creation logic into reusable helpers.
Changes:
- Extracted FK predecessor-map creation into
AddForeignKeyPredecessors(...). - Extracted FK edge creation into an overloaded
AddForeignKeyEdges(...)and introduced shared helper methods for FK key extraction. - Made the
IForeignKeyConstraintoverload ofAddMatchingPredecessorEdgerequire an explicitcheckStoreGeneratedargument.
roji
approved these changes
Apr 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.