Fix query filter parameter naming for primary constructors#38135
Closed
aw0lid wants to merge 1 commit intodotnet:mainfrom
Closed
Fix query filter parameter naming for primary constructors#38135aw0lid wants to merge 1 commit intodotnet:mainfrom
aw0lid wants to merge 1 commit intodotnet:mainfrom
Conversation
Member
|
Thanks, but I submitted #38136 for 10.0.7 with an extra safety check and appcontext switches. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a regression introduced in 10.0.6 where queries using
HasQueryFilterfail when the filter references a primary constructor parameter.Root Cause
When a query filter captures a primary constructor parameter, the C# compiler generates a backing field with a name like
<variable>P. TheExpressionTreeFuncletizerwas using the rawMember.Namefor the parameter name without sanitization, resulting in invalid SQL parameter names (e.g.,@ef_filter__<tenantUuid>P) which causes aSqlException.Fix
Applied
SanitizeCompilerGeneratedNameto the member name in the_generateContextAccessorsblock withinExpressionTreeFuncletizer.cs. This ensures that angle brackets and other compiler-generated characters are stripped before the SQL parameter name is constructed.Fixes #38132