Allow custom build configurations in MigrationsBundleCommand#38206
Merged
AndriySvyryd merged 1 commit intoMay 1, 2026
Merged
Conversation
Previously only Debug and Release configurations were forwarded to dotnet publish; any other configuration name was silently dropped, causing the bundle to be built with the default configuration instead of the one the user specified. Fixes dotnet#38193
AndriySvyryd
approved these changes
May 1, 2026
Member
|
Thanks for your contribution |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #38193.
Problem
dotnet ef migrations bundle --configuration <Name>only forwarded the configuration to the innerdotnet publishcall when the value wasDebugorRelease. Any other configuration name (e.g.EfBundle) was silently dropped, so the bundle was built with the default configuration instead of the one the user requested.Root cause
The Debug/Release whitelist was added in 1422c65 ("Bundles: Flow configuration from project", #25906) so that auto-detected project configurations would not flow through unfiltered. However, the same check also blocked user-explicit
--configurationvalues, which by then had already been validated bydotnet publishitself.Fix
Forward the configuration whenever it is non-empty.
dotnet publishis responsible for validating that the configuration name exists in the project; theeftool should not second-guess it.Verification
net472andnet10.0targets ofsrc/ef/ef.csproj.test/ef.Testssuite passes (6/6).The execution path of
MigrationsBundleCommand.Executeshells out todotnet publishand is not unit-tested today; happy to extract the publish-args construction into a testable helper if reviewers prefer.