Trim LF from EmscriptenVersion and EmscriptenRevision variables#1534
Merged
akoeplinger merged 1 commit intodotnet:mainfrom Jan 21, 2026
Merged
Conversation
akoeplinger
pushed a commit
that referenced
this pull request
Jan 21, 2026
Thanks to #393 , it is now possible to reference EmscriptenVersion from csproj and similar files. This allows referencing the appropriate wasm file for the runtime version within a nuget package. e.g. https://github.com/yamachu/SharpOpenJTalk/blob/d98afa9f11f9c780f63750ae1ba7c31d9e21097c/library/lang/nuget/SharpOpenJTalk.Lang.props#L10 However, since a line feed (LF, 0x0a) character exists at the end of the file, the variable becomes difficult to use unless `Trim` is applied. Therefore, I have modified the code to trim the variable at the point where it is defined, making it more intuitive and easier for users to handle. ```sh $ cat /usr/local/share/dotnet/packs/Microsoft.NET.Runtime.Emscripten.3.1.56.Sdk.osx-arm64/10.0.1/tools/emscripten/emscripten-version.txt|xxd 00000000: 2233 2e31 2e35 3622 0a "3.1.56". $ cat /usr/local/share/dotnet/packs/Microsoft.NET.Runtime.Emscripten.3.1.56.Sdk.osx-arm64/10.0.1/tools/emscripten/emscripten-revision.txt|xxd 00000000: 3537 6232 3162 3866 6463 6265 3365 6262 57b21b8fdcbe3ebb 00000010: 3532 3331 3738 6237 3934 3635 3235 3436 523178b794652546 00000020: 3638 6561 6234 3038 0a 68eab408. ``` (cherry picked from commit 34ea87b)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks to #393 , it is now possible to reference EmscriptenVersion from csproj and similar files.
This allows referencing the appropriate wasm file for the runtime version within a nuget package.
e.g. https://github.com/yamachu/SharpOpenJTalk/blob/d98afa9f11f9c780f63750ae1ba7c31d9e21097c/library/lang/nuget/SharpOpenJTalk.Lang.props#L10
However, since a line feed (LF, 0x0a) character exists at the end of the file, the variable becomes difficult to use unless
Trimis applied.Therefore, I have modified the code to trim the variable at the point where it is defined, making it more intuitive and easier for users to handle.