Conversation
rynowak
commented
Apr 25, 2019
| // See comments on HttpClientMappingRegistry. | ||
| private static void ReserveClient(IHttpClientBuilder builder, Type type, string name) | ||
| { | ||
| var registry = (HttpClientMappingRegistry)builder.Services.Single(sd => sd.ServiceType == typeof(HttpClientMappingRegistry)).ImplementationInstance; |
Member
Author
There was a problem hiding this comment.
@davidfowl if you don't like this I have another cool idea b44b459
Member
There was a problem hiding this comment.
This is horrible but it's less horrible than the other way.
There was a problem hiding this comment.
I really wish you had dont the cool idea way - just hit a bug with this in Orchard Core. The Cool Way would have worked :(
Member
Author
There was a problem hiding this comment.
I was trying to get @davidfowl to allow ConditionalWeakTable into the codebase for years 😆
davidfowl
reviewed
May 1, 2019
| // Misc infrastructure | ||
| // | ||
| services.TryAddEnumerable(ServiceDescriptor.Singleton<IHttpMessageHandlerBuilderFilter, LoggingHttpMessageHandlerBuilderFilter>()); | ||
| services.TryAddSingleton(new HttpClientMappingRegistry()); |
Member
There was a problem hiding this comment.
Add a comment here saying that this has to be an instance or it'll break the upstream code.
davidfowl
approved these changes
May 1, 2019
This was referenced May 1, 2019
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds tracking for the relationship between named clients and the types
that they are bound to.
This allows us to throw a better in common cases that won't work: