Fix TaskCache on net452#195
Merged
Merged
Conversation
cesarblum
commented
Feb 22, 2017
| /// by <c>Task.CompletedTask</c>. | ||
| /// </remarks> | ||
| #if NET451 | ||
| #if NET451 || NET452 |
Author
There was a problem hiding this comment.
I don't really like it, but I want to get things going.
Why don't we just do Task.FromResult(0) for both targets?
There was a problem hiding this comment.
you can do #if !NETSTANDARD*, so each assembly would not have own completed task instance at least on core.
Member
There was a problem hiding this comment.
Because Task.CompletedTask is the one we want to use long term, but it's new in 4.6.
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To make aspnet/Identity#1111 build without the hack in the .csproj.