-
Notifications
You must be signed in to change notification settings - Fork 850
Package references updates #3179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| Package: Microsoft.Extensions.Configuration.Binder | ||
| TFM: .NETStandard2.0 | ||
| Removed: | ||
| Microsoft.Extensions.Configuration |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In this case, it turns out only code from M.E.Configuration.Abstraction is used. So the package removed the M.E.Configuration dependency and added a M.E.Configuration.Abstractions dependency.
| Package: Microsoft.Extensions.Hosting.Abstractions | ||
| TFM: .NETCoreApp5.0 | ||
| Removed: | ||
| Microsoft.Extensions.Logging.Abstractions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a change we noticed during our ingestion. Along with the change in M.E.Options
docs/ReferenceChanges.md
Outdated
| Package: Microsoft.Extensions.DependencyInjection | ||
| TFM: .NETFramework4.6.1 | ||
| Added: | ||
| System.Threading.Tasks.Extensions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just checked, these were in the previous closure as well since Microsoft.Bcl.AsyncInterfaces included a reference to it so this is a false positive. I didn't include that package in the set of packages I was analyzing. The same goes for M.E.Hosting.Abstraction.
ericstj
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These all look reasonable. Thank you for analyzing this.
analogrelay
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Assuming none of the assemblies in these packages were actually used, this looks fine to me.
| Package: Microsoft.Extensions.Logging.EventLog | ||
| TFM: .NETFramework4.6.1 | ||
| Removed: | ||
| System.Diagnostics.EventLog |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this because the type is just part of .NET Framework 4.6.1? (@ericstj ?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes
|
Announcement made in aspnet/Announcements#415 |
Addresses item in dotnet/aspnetcore#19254
As we discussed previously, we wanted to understand the changes in out package graph and make appropriate announcements. I made a quick analyzer that found the following.
I've noticed that dotnet/runtime does a few things differently:
I've opened this as a PR so we can review each change if necessary. However, I don't plan to check this in.