Merged
Conversation
danmoseley
reviewed
May 23, 2023
test/Analyzers/Microsoft.Extensions.ExtraAnalyzers/Common/CallAnalysis/ArraysTests.cs
Outdated
Show resolved
Hide resolved
geeknoid
force-pushed
the
geeknoid/analyzers
branch
from
c66e912 to
e93439f
Compare
danmoseley
reviewed
May 23, 2023
test/Analyzers/Microsoft.Extensions.LocalAnalyzers/ApiLifecycle/Data/Time.json
Outdated
Show resolved
Hide resolved
Member
|
Are all these tests new code, and need review, or just being copied over? BTW why does description say 'null' above |
Member
Author
|
@danmoseley I don't know why the description said "null". Yes, these are being bulk copied with minor edits to make things work. I'm not sure how come we decided to not copy these tests over in the first place. |
geeknoid
force-pushed
the
geeknoid/analyzers
branch
from
e93439f to
0ac2efc
Compare
danmoseley
approved these changes
May 23, 2023
Member
danmoseley
left a comment
danmoseley
left a comment
There was a problem hiding this comment.
LGTM given tests were already reviewed. with caveat about R9 stuff being added
geeknoid
force-pushed
the
geeknoid/analyzers
branch
from
0ac2efc to
209d2c1
Compare
geeknoid
added a commit
that referenced
this pull request
May 23, 2023
Co-authored-by: Martin Taillefer <mataille@microsoft.com>
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Microsoft Reviewers: Open in CodeFlow