Skip to content

Fix standard hedging#4633

Merged
geeknoid merged 1 commit intorelease/8.0from
mtomka/fix-hedging
Oct 30, 2023
Merged

Fix standard hedging#4633
geeknoid merged 1 commit intorelease/8.0from
mtomka/fix-hedging

Conversation

@martintmk
Copy link
Contributor

@martintmk martintmk commented Oct 30, 2023

Hedging should assign the action resilience context to cloned request message, otherwise the inner handler might use incorrect context.

Microsoft Reviewers: Open in CodeFlow

@ghost ghost assigned martintmk Oct 30, 2023
@joperezr joperezr added the servicing-consider Shiproom approval is required for the issue label Oct 30, 2023
@joperezr
Copy link
Member

Thanks for the PR @martintmk, we have now began our lock down and stabilization period for 8.0. Do you think this PR is something we should consider for 8.0, or is it okay to let this one be part of 8.1 instead?

@joperezr joperezr removed the servicing-consider Shiproom approval is required for the issue label Oct 30, 2023
@martintmk
Copy link
Contributor Author

Thanks for the PR @martintmk, we have now began our lock down and stabilization period for 8.0. Do you think this PR is something we should consider for 8.0, or is it okay to let this one be part of 8.1 instead?

Without this PR the standard hedging is basically broken, so is a must from my perspective.

@geeknoid geeknoid merged commit c335af4 into release/8.0 Oct 30, 2023
@geeknoid geeknoid deleted the mtomka/fix-hedging branch October 30, 2023 16:32
@joperezr
Copy link
Member

Chatted with @martintmk offline, this is approved for 8.0

@ghost ghost locked as resolved and limited conversation to collaborators Nov 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants