Skip to content

Addresses #4634 #4638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
geeknoid merged 1 commit into from
Oct 30, 2023
Merged

Addresses #4634 #4638

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Libraries/Microsoft.Extensions.Http.Diagnostics/Logging/LoggingOptions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ public class LoggingOptions
{
private const int MaxIncomingBodySize = 1_572_864; // 1.5 MB
private const int Millisecond = 1;
private const int Hour = 60000 * 60; // 1 hour
private const int Minute = 60000;
Copy link
Contributor

@RussKie RussKie Oct 30, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
private const int Minute = 60000;
private const int Minute = 60_000;

private const int DefaultReadSizeLimit = 32 * 1024; // ≈ 32K
private const OutgoingPathLoggingMode DefaultPathLoggingMode = OutgoingPathLoggingMode.Formatted;
private const HttpRouteParameterRedactionMode DefaultPathParameterRedactionMode = HttpRouteParameterRedactionMode.Strict;
Expand Down Expand Up @@ -67,7 +67,7 @@ public class LoggingOptions
/// <remarks>
/// The value should be in the range of 1 millisecond to 1 minute.
/// </remarks>
[TimeSpan(Millisecond, Hour)]
[TimeSpan(Millisecond, Minute)]
public TimeSpan BodyReadTimeout { get; set; } = TimeSpan.FromSeconds(1);

/// <summary>
Expand Down