Skip to content

[dev] Update dependencies from dotnet/arcade #6184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
dotnet-maestro wants to merge 13 commits into from
Closed

[dev] Update dependencies from dotnet/arcade #6184

dotnet-maestro wants to merge 13 commits into from

Conversation

@dotnet-maestro
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented Mar 24, 2025 •
edited
Loading

This pull request updates the following dependencies

From https://github.com/dotnet/arcade

Microsoft Reviewers: Open in CodeFlow

@dotnet-maestro
Update dependencies from https://github.com/dotnet/arcade build 20250…
3261a82 
…321.1

Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Helix.Sdk
 From Version 10.0.0-beta.25126.4 -> To Version 10.0.0-beta.25171.1
@dotnet-maestro dotnet-maestro bot requested a review from a team as a code owner March 24, 2025 05:01
@MackinnonBuck
Copy link
Member

MackinnonBuck commented Mar 26, 2025

/azp run

@azure-pipelines
Copy link

azure-pipelines bot commented Mar 26, 2025

Azure Pipelines successfully started running 1 pipeline(s).

MackinnonBuck and others added 3 commits March 27, 2025 13:31
@MackinnonBuck
Merge branch 'dev' into darc-dev-d94a4fb2-8597-4ee6-aa16-d6cf8e816f24
6f565af
@dotnet-maestro
Update dependencies from https://github.com/dotnet/arcade build 20250…
de043f1 
…328.2

Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Helix.Sdk
 From Version 10.0.0-beta.25126.4 -> To Version 10.0.0-beta.25178.2
@wtgodbe
Merge branch 'dev' into darc-dev-d94a4fb2-8597-4ee6-aa16-d6cf8e816f24
81661ad
@wtgodbe wtgodbe enabled auto-merge (squash) April 3, 2025 16:20
@RussKie
Copy link
Contributor

RussKie commented Apr 3, 2025

I think we'll need help from @Youssef1313 in this repo after he's done with dotnet/aspire

dotnet-maestro bot and others added 6 commits April 7, 2025 05:00
@dotnet-maestro
Update dependencies from https://github.com/dotnet/arcade build 20250…
15d0ebe 
…406.1

Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Helix.Sdk
 From Version 10.0.0-beta.25126.4 -> To Version 10.0.0-beta.25206.1
@dotnet-maestro
Update dependencies from https://github.com/dotnet/arcade build 20250…
78d0d8c 
…412.1

Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Helix.Sdk
 From Version 10.0.0-beta.25126.4 -> To Version 10.0.0-beta.25212.1
@dotnet-maestro
Update dependencies from https://github.com/dotnet/arcade build 20250…
4128173 
…416.2

Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Helix.Sdk
 From Version 10.0.0-beta.25126.4 -> To Version 10.0.0-beta.25216.2
@dotnet-maestro
Update dependencies from https://github.com/dotnet/arcade build 20250…
ac67d2b 
…417.1

Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Helix.Sdk
 From Version 10.0.0-beta.25126.4 -> To Version 10.0.0-beta.25217.1
@radical
Merge remote-tracking branch 'origin/dev' into darc-dev-d94a4fb2-8597…
eeeedbf 
…-4ee6-aa16-d6cf8e816f24
@dotnet-maestro
Update dependencies from https://github.com/dotnet/arcade build 20250…
2b20cd4 
…425.4

Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Helix.Sdk
 From Version 10.0.0-beta.25126.4 -> To Version 10.0.0-beta.25225.4
@RussKie
Copy link
Contributor

RussKie commented Apr 28, 2025

@Youssef1313 @ViktorHofer what are out options here?

test/Libraries/Microsoft.Extensions.Caching.Hybrid.Tests/Microsoft.Extensions.Caching.Hybrid.Tests.csproj(0,0): error NU1202: (NETCORE_ENGINEERING_TELEMETRY=Restore) Package xunit.runner.visualstudio 3.0.2 is not compatible with net462 (.NETFramework,Version=v4.6.2). Package xunit.runner.visualstudio 3.0.2 supports:
  - net472 (.NETFramework,Version=v4.7.2)
  - net6.0 (.NETCoreApp,Version=v6.0)

@Youssef1313
Copy link
Member

Youssef1313 commented Apr 28, 2025

Any reason why Microsoft.Extensions.Caching.Hybrid.Tests is still net462?

@ViktorHofer
Copy link
Member

ViktorHofer commented Apr 28, 2025

Arcade now requires test application to target >= net472 as those are the minimum run requirements for xunit.runner.visualstudio and xunit v3. You can opt-out of that if you need to but I would rather recommend to update .NET Framework test project TFMs.

dotnet-maestro bot added 2 commits May 5, 2025 05:01
@dotnet-maestro
Update dependencies from https://github.com/dotnet/arcade build 20250…
0c1ceb0 
…503.1

Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Helix.Sdk
 From Version 10.0.0-beta.25126.4 -> To Version 10.0.0-beta.25253.1
@dotnet-maestro
Update dependencies from https://github.com/dotnet/arcade build 20250…
e80c5c5 
…509.2

Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Helix.Sdk
 From Version 10.0.0-beta.25126.4 -> To Version 10.0.0-beta.25259.2
@ViktorHofer
Copy link
Member

ViktorHofer commented May 12, 2025

Better get this in sooner than later. The PR already shows 180 file changes.

@RussKie
Copy link
Contributor

RussKie commented May 13, 2025

@ViktorHofer @Youssef1313 many M.E.* libraries targets net462.
image

AFAIK, we can't update the TFM. Do we have any other options? dotnet/runtime targets net462 as well, how is this not a problem there?

/cc: @joperezr @mwierzchowski

@ViktorHofer
Copy link
Member

ViktorHofer commented May 13, 2025 •
edited
Loading

dotnet/runtime's test apps target net481. We upgraded them for exactly this reason. At the end of the day, apps run on NET Framework 4.8 or 4.8.1 anyway. These days we are less concerned about testing specific quirks (which shouldn't apply to this repo).

Upgrading to at least net472 is a requirement to use xunit v3 which we plan to switch to (aspire already does, thanks to @Youssef1313).

@RussKie
Copy link
Contributor

RussKie commented May 13, 2025

Ah, thank you for the information. I'll update the tests to target net481.

@RussKie RussKie requested review from a team as code owners May 13, 2025 08:18
@RussKie RussKie requested a review from a team as a code owner May 13, 2025 08:18
ViktorHofer
ViktorHofer reviewed May 13, 2025
View reviewed changes
Directory.Build.targets

<!-- Legacy targets do not support attributes for a nullable context thus suppressing null check warnings -->
<NoWarn Condition="'$(TargetFramework)' == 'net462' or '$(TargetFramework)' == 'netstandard2.0'">$(NoWarn);CA1062</NoWarn>
<NoWarn Condition="'$(TargetFramework)' == 'net462' or '$(TargetFramework)' == 'net481' or '$(TargetFramework)' == 'netstandard2.0'">$(NoWarn);CA1062</NoWarn>
Copy link
Member

@ViktorHofer ViktorHofer May 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's better to not hardcode specific TargetFrameworkMonikers in case they change again (for whatever reason). This also makes sure that it applies to every .NET Framework and .NET Standard version.

Suggested change
<NoWarn Condition="'$(TargetFramework)' == 'net462' or '$(TargetFramework)' == 'net481' or '$(TargetFramework)' == 'netstandard2.0'">$(NoWarn);CA1062</NoWarn>
<NoWarn Condition="'$(TargetFrameworkIdentifier)' != '.NETCoreApp'">$(NoWarn);CA1062</NoWarn>

Copy link
Member

@ViktorHofer ViktorHofer May 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feedback applies to all other changes in this commit as well.

@ViktorHofer
Copy link
Member

ViktorHofer commented May 13, 2025

Make sure to revert changes from this folder:

image

That was a Maestro synchronization bug that got fixed meanwhile but the files in this PR need to get manually removed.

@RussKie RussKie closed this May 14, 2025
auto-merge was automatically disabled May 14, 2025 05:20

Pull request was closed

@RussKie RussKie deleted the darc-dev-d94a4fb2-8597-4ee6-aa16-d6cf8e816f24 branch May 14, 2025 05:20
@RussKie RussKie mentioned this pull request May 19, 2025
Closed
@github-actions github-actions bot locked and limited conversation to collaborators Jun 13, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@ViktorHofer ViktorHofer ViktorHofer left review comments

@wtgodbe wtgodbe wtgodbe approved these changes

Assignees

No one assigned

Labels

area-infrastructure

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@MackinnonBuck @RussKie @Youssef1313 @ViktorHofer @wtgodbe @radical