Rename VectorStoreVectorAttribute dimensions constructor parameter#7460
Merged
jeffhandley merged 1 commit intomainfrom Apr 9, 2026
Merged
Rename VectorStoreVectorAttribute dimensions constructor parameter#7460jeffhandley merged 1 commit intomainfrom
jeffhandley merged 1 commit intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Renames the VectorStoreVectorAttribute constructor parameter from Dimensions to dimensions to fix a public API naming mistake (source-level breaking change) and updates internal usages/baselines accordingly.
Changes:
- Rename
VectorStoreVectorAttribute(int Dimensions)toVectorStoreVectorAttribute(int dimensions)and adjust validation/argument naming. - Update all in-repo attribute usages to use the corrected named argument
dimensions:. - Update the VectorData Abstractions API description/baseline JSON to reflect the parameter rename.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| test/Libraries/Microsoft.Extensions.VectorData.Abstractions.Tests/CollectionModelBuilderTests.cs | Updates test attribute usages to dimensions:. |
| src/Libraries/Microsoft.Extensions.VectorData.ConformanceTests/ModelTests/NoDataModelTests.cs | Updates conformance test attribute usage to dimensions:. |
| src/Libraries/Microsoft.Extensions.VectorData.ConformanceTests/ModelTests/BasicModelTests.cs | Updates conformance test attribute usage to dimensions:. |
| src/Libraries/Microsoft.Extensions.VectorData.ConformanceTests/EmbeddingGenerationTests.cs | Updates conformance test attribute usages to dimensions:. |
| src/Libraries/Microsoft.Extensions.VectorData.ConformanceTests/DependencyInjectionTests.cs | Updates conformance test attribute usage to dimensions:. |
| src/Libraries/Microsoft.Extensions.VectorData.Abstractions/RecordAttributes/VectorStoreVectorAttribute.cs | Renames ctor parameter to dimensions and removes now-unneeded naming/analyzer pragmas. |
| src/Libraries/Microsoft.Extensions.VectorData.Abstractions/Microsoft.Extensions.VectorData.Abstractions.json | Updates API member signature to reflect the new parameter name. |
jeffhandley
added
the
breaking-change
jeffhandley
approved these changes
Apr 9, 2026
Member
jeffhandley
left a comment
jeffhandley
left a comment
There was a problem hiding this comment.
This is a subtle, source-breaking change but I approve of making this change. I'll make sure it's included in the release notes.
jeffhandley
pushed a commit
that referenced
this pull request
Apr 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes an unfortunate naming mistake that slipped through, and was picked up by code analysis once we moved the code from the SK repo to dotnet/extensions - the constructor parameter
Dimensionson VectorStoreVectorAttribute should be nameddimensions.This is unfortunately a (minor) user-facing breaking change, albeit a source-only one; it's zero-risk, only a tiny bit of work for users, and it's early enough that it seems OK for us to do something like this (but if people have the opposite opinion we can leave it).
Microsoft Reviewers: Open in CodeFlow