Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses a mismatch in how StorageName is computed in Microsoft.Extensions.VectorData.Abstractions when a provider indicates it uses an external serializer, and updates packaging settings to avoid incorrect compatibility warnings for net462 consumers.
Changes:
- Fix
CollectionModelBuildersoUsesExternalSerializer=truecorrectly causes attribute-specifiedStorageNamevalues to be ignored (by ensuringPropertyInfois set before storage-name application). - Add unit tests covering
StorageNamebehavior withUsesExternalSerializerenabled/disabled. - Disable minimum-supported-TFM compat warnings for this package to prevent incorrect net462 warnings.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| test/Libraries/Microsoft.Extensions.VectorData.Abstractions.Tests/CollectionModelBuilderTests.cs | Adds regression tests validating StorageName behavior with/without UsesExternalSerializer. |
| src/Libraries/Microsoft.Extensions.VectorData.Abstractions/ProviderServices/CollectionModelBuilder.cs | Moves PropertyInfo assignment earlier so storage-name logic can correctly ignore attribute/config when external serialization is used. |
| src/Libraries/Microsoft.Extensions.VectorData.Abstractions/Microsoft.Extensions.VectorData.Abstractions.csproj | Disables minimum-supported-TFM compat errors to avoid incorrect net462 consumer warnings for this package. |
github-actions
Bot
added
area-ai
* Correct StorageName behavior when external serialization is enabled * Disable warning for net462
jeffhandley
approved these changes
Apr 22, 2026
jeffhandley
pushed a commit
that referenced
this pull request
May 5, 2026
* Correct StorageName behavior when external serialization is enabled * Disable warning for net462 (cherry picked from commit 7723587)
This was referenced May 5, 2026
Open
Open
This was referenced May 6, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Microsoft Reviewers: Open in CodeFlow