Renaming function in VS causes a freeze followed by a crash

[0101]

Repro steps

Couldn't repro on any minimal example, probably requires a bigger project. This seems to consistently reproduce on FSharp solution:

1. Open FSharp solution
2. Go to CompilerDiagnostics.fs line 602
3. Rename OutputNameSuggestions to something else via VS Rename... action.

Expected behavior

The function gets renamed to the new name.

Actual behavior

While typing the new name we see the document update in all places correctly in real-time. But when the change is submitted VS shows a popup with "Computing rename information..." while the rest of the UI is frozen and in about a minute it crashes.

• The popup has a Cancel button which works correctly
• Under some circumstances (not sure exactly, but when VS has been running for a while and the rename has been triggered and cancelled a few times) the rename action (when submitted) gets cancelled instantly without renaming anything.

Known workarounds

• Wait until Rename will update X references in Y files message is displayed in the rename box before hitting enter

or

• Cancel the rename operation and do the rename manually

Related information

• The fact that while editing the name in the rename dialogue we can see the document changing accordingly shows that most of the F# functionality is working (finding the symbol and its usages)

Reproduced on

• Windows 11
• Microsoft Visual Studio Enterprise 2022 (64-bit) - Int Preview
  • Version 17.4.0 Preview 3.0 [32928.480.main]

Related issues

• Rename hangs forever #13284
• Refactor Rename doesn't work for simple type rename #13199 (?)

[0101]

This specific case was fixed by: #14274

The general case was hopefully fixed by: #14293

But there can still be pathological cases which will end up with a crash. Example: renaming Range type in FSharp.Compiler.Service