VS Crash due to an exception in a type provider

[smoothdeveloper]

I'm using a given release of FSharp.Data.SqlClient which has a bug, when I edit a .sql file exposed by the type provider, Visual Studio crashes.

Repro steps

1. unzip this package sqlclientcrashvs.zip
2. open the solution in VS2015
3. make sure Library1.fs is open in VS and type checked (few seconds after it is open)
4. open samplecommand.sql in notepad and change the query and save

Expected behavior

VS type checks again

Actual behavior

VS crashes

Known workarounds

None

Related information

• Windows 10
• F# 4.0
• .NET 4.6
• VS 2015 Pro
• SqlFile crashes Visual Studio fsprojects/FSharp.Data.SqlClient#240
• Dispose cache only once fsprojects/FSharp.Data.SqlClient#241

[cartermp]

Expectation here is that rather than VS crashing, we get an indication that the Type Provider failed. I think that's perfectly valid.

[smoothdeveloper]

Actually, for expected behaviour, I'd be looking for squiggles at the type provider instanciation with the message or message + full stack trace of the exception.

I think I've seen this behaviour in other occurences of buggy TP where it would do squiggles with the message.

Having VS crash is also not that helpful for TP authors.