Bugfix :: Fix type definition metadata: duplicate methods, event flags#19341
Merged
Bugfix :: Fix type definition metadata: duplicate methods, event flags#19341
Conversation
Contributor
✅ No release notes required |
T-Gro
force-pushed
the
codegen/fix-typedefs-and-exceptions
branch
4 times, most recently
from
63e792d to
3b64857
Compare
T-Gro
force-pushed
the
codegen/fix-typedefs-and-exceptions
branch
from
3b64857 to
56491f1
Compare
For DefaultAugmentation(false) (NoHelpers), EraseUnions generates a get_<CaseName> method but no corresponding <CaseName> property for nullary cases. The method discard correctly removes the user's get_<CaseName> method, but the property discard only checked tdef2.Properties — which is empty for NoHelpers — leaving an orphaned property whose getter method ref points to the discarded method. Fix: also check tdef2.Methods for a corresponding get_ method when deciding whether to discard a user property. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Add tolerance for async cancellation token cleanup on slower CI platforms. The Cancellable.HasCancellationToken assertion can fail when the AsyncLocal cleanup from previous async operations has not yet propagated. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Member
Author
|
/azp run fsharp-ci |
|
Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command. |
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
T-Gro
changed the title
AzDo agent node.exe crashed: 'Assertion failed: new_time >= loop->time, file src/win/core.c, line 327' (exit 57005/0xDEAD). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
- Release notes: keep both PR entries and main entries - ModuleReaderCancellationTests: use main's 200ms sleep (more robust) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…and-exceptions Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
abonie
approved these changes
Mar 23, 2026
...s/FSharp.Compiler.ComponentTests/EmittedIL/CodeGenRegressions/CodeGenRegressions_TypeDefs.fs
Outdated
Show resolved
Hide resolved
github-project-automation
bot
moved this from New
to In Progress
in F# Compiler and Tooling
- Remove tracked .copilot-pid file - Remove unused getActualIL helper and FSharp.Test.Utilities import - Add IL verification tests for all three fixes: - Issue #5834: Verify specialname flag on abstract event accessors - Issue #14321: Verify DU case and IWSAM coexist without duplicates - Issue #16565: Verify DefaultAugmentation(false) produces correct methods Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI
pushed a commit
that referenced
this pull request
Mar 31, 2026
#19341) Co-authored-by: abonie <20281641+abonie@users.noreply.github.com>
Copilot AI
pushed a commit
that referenced
this pull request
Mar 31, 2026
#19341) Co-authored-by: abonie <20281641+abonie@users.noreply.github.com>
Copilot AI
pushed a commit
that referenced
this pull request
Mar 31, 2026
#19341) Co-authored-by: abonie <20281641+abonie@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes type definitions emitting duplicate or incorrect metadata entries.
DefaultAugmentation(false)#16565 —DefaultAugmentation(false)no longer causes duplicate method table entriesspecialname#5834 — abstract eventadd_/remove_accessors now emitted withSpecialNameflag