Add regression tests: #14308 + #14310, Signature generation improvements#19490
Merged
Add regression tests: #14308 + #14310, Signature generation improvements#19490
Conversation
…ovements Test 1 (#14310): Verify struct with private field roundtrips correctly when signature includes the private field (as generated by --sig). Test 2 (#14308): Verify Sealed, AbstractClass, Interface and Class attributes roundtrip correctly in signature generation. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
T-Gro
added
NO_RELEASE_NOTES
Contributor
|
abonie
approved these changes
Mar 24, 2026
github-project-automation
bot
moved this from New
to In Progress
in F# Compiler and Tooling
github-project-automation
bot
moved this from In Progress
to Done
in F# Compiler and Tooling
This was referenced Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #14308
Fixes #14310
Adds two regression tests for signature generation:
Signature generation must include private field info in case of Structs #14310 (struct private field): Verifies that a struct type with a private field roundtrips correctly when the signature includes the private field (as generated by
fsc --sig). Previously, the generated.fsiomitted private struct fields, causing compilation failure when used together.Update signature generation to include Sealed/Class/Interface attribute for OO-style type constructs #14308 (Sealed/Class/Interface attributes): Verifies that
[<Sealed>],[<AbstractClass>],[<Interface>], and[<Class>]attributes roundtrip correctly in signature files. Previously, the generated.fsiomitted these attributes, causing compilation mismatches.