Skip to content

Parser: fix unexpected diagnostics in debug builds, improve error messages #19730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
T-Gro merged 3 commits into from
May 14, 2026
Merged

Parser: fix unexpected diagnostics in debug builds, improve error messages #19730

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b785b82
Parser: fix unexpected diagnostics in debug builds, improve error mes…
auduchinok May 13, 2026
1ad14e3
Release notes
auduchinok May 13, 2026
bb53348
Merge branch 'main' into parser-diagnostics-accessors
T-Gro May 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions docs/release-notes/.FSharp.Compiler.Service/11.0.100.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@
* Fix signature generation: type params with special characters missing backtick escaping. ([Issue #19595](https://github.com/dotnet/fsharp/issues/19595), [PR #19609](https://github.com/dotnet/fsharp/pull/19609))
* Fix internal error when using custom attribute with `[<Optional>]` value type parameter and no `[<DefaultParameterValue>]`. ([Issue #8353](https://github.com/dotnet/fsharp/issues/8353), [PR #19484](https://github.com/dotnet/fsharp/pull/19484))
* Fix parallel compilation of scripts ([PR #19649](https://github.com/dotnet/fsharp/pull/19649))
* Parser: fix unexpected diagnostics in debug builds, improve error messages ([PR #19730](https://github.com/dotnet/fsharp/pull/19730))

### Added

Expand Down
8 changes: 8 additions & 0 deletions src/Compiler/Driver/CompilerDiagnostics.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -497,6 +497,8 @@ module OldStyleMessages =
let NONTERM_classDefnMemberE () = Message("NONTERM.classDefnMember", "")
let NONTERM_defnBindingsE () = Message("NONTERM.defnBindings", "")
let NONTERM_classMemberSpfnE () = Message("NONTERM.classMemberSpfn", "")
let NONTERM_classMemberSpfnGetSetElementsE () = Message("NONTERM.classMemberSpfnGetSetElements", "")
let NONTERM_autoPropsDefnDeclE () = Message("NONTERM.autoPropsDefnDecl", "")
let NONTERM_valSpfnE () = Message("NONTERM.valSpfn", "")
let NONTERM_tyconSpfnE () = Message("NONTERM.tyconSpfn", "")
let NONTERM_anonLambdaExprE () = Message("NONTERM.anonLambdaExpr", "")
Expand Down Expand Up @@ -1470,6 +1472,12 @@ type Exception with
| [ Parser.NONTERM_classMemberSpfn ] ->
os.AppendString(NONTERM_classMemberSpfnE().Format)
true
| [ Parser.NONTERM_classMemberSpfnGetSetElements ] ->
os.AppendString(NONTERM_classMemberSpfnGetSetElementsE().Format)
true
| [ Parser.NONTERM_autoPropsDefnDecl ] ->
os.AppendString(NONTERM_autoPropsDefnDeclE().Format)
true
| [ Parser.NONTERM_valSpfn ] ->
os.AppendString(NONTERM_valSpfnE().Format)
true
Expand Down
6 changes: 6 additions & 0 deletions src/Compiler/FSStrings.resx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -788,6 +788,12 @@
</data>
<data name="NONTERM.classMemberSpfn" xml:space="preserve">
<value> in member signature</value>
</data>
<data name="NONTERM.classMemberSpfnGetSetElements" xml:space="preserve">
<value> in property definition</value>
</data>
<data name="NONTERM.autoPropsDefnDecl" xml:space="preserve">
<value> in auto property definition</value>
</data>
<data name="NONTERM.valSpfn" xml:space="preserve">
<value> in value signature</value>
Expand Down
10 changes: 10 additions & 0 deletions src/Compiler/xlf/FSStrings.cs.xlf
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 10 additions & 0 deletions src/Compiler/xlf/FSStrings.de.xlf
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 10 additions & 0 deletions src/Compiler/xlf/FSStrings.es.xlf
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 10 additions & 0 deletions src/Compiler/xlf/FSStrings.fr.xlf
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 10 additions & 0 deletions src/Compiler/xlf/FSStrings.it.xlf
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 10 additions & 0 deletions src/Compiler/xlf/FSStrings.ja.xlf
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 10 additions & 0 deletions src/Compiler/xlf/FSStrings.ko.xlf
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 10 additions & 0 deletions src/Compiler/xlf/FSStrings.pl.xlf
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 10 additions & 0 deletions src/Compiler/xlf/FSStrings.pt-BR.xlf
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 10 additions & 0 deletions src/Compiler/xlf/FSStrings.ru.xlf
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 10 additions & 0 deletions src/Compiler/xlf/FSStrings.tr.xlf
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 10 additions & 0 deletions src/Compiler/xlf/FSStrings.zh-Hans.xlf
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 10 additions & 0 deletions src/Compiler/xlf/FSStrings.zh-Hant.xlf
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion tests/service/data/SyntaxTree/Member/Abstract - Property 03.fs.bsl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,4 +45,4 @@ ImplFile

(6,0)-(6,1) parse error Unexpected syntax or possible incorrect indentation: this token is offside of context started at position (4:5). Try indenting this further.
To continue using non-conforming indentation, pass the '--strict-indentation-' flag to the compiler, or set the language version to F# 7.
(6,0)-(6,1) parse error Incomplete structured construct at or before this point in member definition. Expected identifier, '(', '(*)' or other token.
(6,0)-(6,1) parse error Incomplete structured construct at or before this point in property definition. Expected identifier, '(', '(*)' or other token.
2 changes: 1 addition & 1 deletion tests/service/data/SyntaxTree/Member/Auto property 05.fs.bsl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,4 +66,4 @@ ImplFile
WarnDirectives = []
CodeComments = [] }, set []))

(4,15)-(5,4) parse error Incomplete structured construct at or before this point in member definition. Expected identifier or other token.
(4,15)-(5,4) parse error Incomplete structured construct at or before this point in auto property definition. Expected identifier or other token.
2 changes: 1 addition & 1 deletion tests/service/data/SyntaxTree/Member/Auto property 06.fs.bsl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,4 +43,4 @@ ImplFile
WarnDirectives = []
CodeComments = [] }, set []))

(4,18)-(4,19) parse error Unexpected symbol '=' in member definition
(4,18)-(4,19) parse error Unexpected symbol '=' in auto property definition
2 changes: 1 addition & 1 deletion tests/service/data/SyntaxTree/Member/Auto property 08.fs.bsl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,4 +46,4 @@ ImplFile

(6,0)-(6,1) parse error Unexpected syntax or possible incorrect indentation: this token is offside of context started at position (4:22). Try indenting this further.
To continue using non-conforming indentation, pass the '--strict-indentation-' flag to the compiler, or set the language version to F# 7.
(6,0)-(6,1) parse error Incomplete structured construct at or before this point. Expected identifier, '(', '(*)' or other token.
(6,0)-(6,1) parse error Incomplete structured construct at or before this point in property definition. Expected identifier, '(', '(*)' or other token.
2 changes: 1 addition & 1 deletion tests/service/data/SyntaxTree/Member/Auto property 09.fs.bsl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,4 +69,4 @@ ImplFile

(5,4)-(5,10) parse error Unexpected syntax or possible incorrect indentation: this token is offside of context started at position (4:23). Try indenting this further.
To continue using non-conforming indentation, pass the '--strict-indentation-' flag to the compiler, or set the language version to F# 7.
(5,4)-(5,10) parse error Incomplete structured construct at or before this point. Expected identifier, '(', '(*)' or other token.
(5,4)-(5,10) parse error Incomplete structured construct at or before this point in property definition. Expected identifier, '(', '(*)' or other token.
2 changes: 1 addition & 1 deletion tests/service/data/SyntaxTree/Member/Auto property 10.fs.bsl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,4 +45,4 @@ ImplFile

(5,0)-(5,0) parse error Unexpected syntax or possible incorrect indentation: this token is offside of context started at position (4:22). Try indenting this further.
To continue using non-conforming indentation, pass the '--strict-indentation-' flag to the compiler, or set the language version to F# 7.
(5,0)-(5,0) parse error Incomplete structured construct at or before this point. Expected identifier, '(', '(*)' or other token.
(5,0)-(5,0) parse error Incomplete structured construct at or before this point in property definition. Expected identifier, '(', '(*)' or other token.
Loading