Fix #19664: Static extension overload resolution for generic types#19736
Open
T-Gro wants to merge 2 commits into
Open
Fix #19664: Static extension overload resolution for generic types#19736T-Gro wants to merge 2 commits into
T-Gro wants to merge 2 commits into
Conversation
…ad resolution with explicit type args) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…r (TDD green) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
❗ Release notes required
Warning No PR link found in some release notes, please consider adding it.
|
Contributor
|
🔍 Tooling Safety Check — Bypassed (non-fork) (scanned-sha)1d647200b286e43951fb9462fcf29579bc3809d9(/scanned-sha)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #19664
When resolving
Type<TArg>.Member(...), the name resolver usesLookupIsInstance.Yes(dot-expression form) but finds static intrinsic members. The extension member lookup then also filters for instance-only extensions, missing the static extension overloads entirely.The fix detects this mismatch and relaxes the filter to
LookupIsInstance.Ambivalentso static extensions are included in overload resolution.