Skip to content
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/Compiler/Service/FSharpCheckerResults.fs
Original file line number Diff line number Diff line change
Expand Up @@ -1631,11 +1631,17 @@ type internal TypeCheckInfo
| None -> ValueNone
| _ -> ValueNone

let isDiscardIdentifier =
match residueOpt, origLongIdentOpt with
| None, Some [ "_" ] -> true
| _ -> false

match nameResItems with
| NameResResult.Cancel(denv, m) -> Some([], denv, m)
| NameResResult.Members(FilterRelevantItems getItem exactMatchResidueOpt (items, denv, m)) ->
// lookup based on name resolution results successful
Some(items |> List.map (CompletionItem (getType ()) ValueNone), denv, m)
| _ when isDiscardIdentifier -> None
| _ ->
match origLongIdentOpt with
| None -> None
Expand Down
21 changes: 21 additions & 0 deletions tests/FSharp.Compiler.Service.Tests/TooltipTests.fs
Original file line number Diff line number Diff line change
Expand Up @@ -399,6 +399,9 @@ let assertNameTagInTooltip expectedTag expectedName (tooltip: ToolTipText) =
let desc = tags |> Array.map (fun t -> sprintf "(%A, %s)" t.Tag t.Text) |> String.concat ", "
Assert.True(found, sprintf "Expected tag %A with text '%s' in tooltip, but found: %s" expectedTag expectedName desc)

let assertToolTipIsEmpty (ToolTipText(items)) =
Assert.Empty items

let normalize (s: string) = s.Replace("\r\n", "\n").Replace("\n\n", "\n")

[<Fact>]
Expand Down Expand Up @@ -594,6 +597,24 @@ let y = normaliz{caret}e' 5
|> assertAndGetSingleToolTipText
|> Assert.shouldBeEquivalentTo "val normalize': x: int -> int"

[<Fact>]
let ``Wildcard lambda parameter inside member with underscore instance identifier has no tooltip`` () =
Checker.getTooltip """
type T () =
member _.M () =
fun _{caret} -> ()
"""
|> assertToolTipIsEmpty

[<Fact>]
let ``Wildcard let binding inside member with underscore instance identifier has no tooltip`` () =
Checker.getTooltip """
type T () =
member _.N () =
let _{caret} = () in ()
"""
|> assertToolTipIsEmpty

// https://github.com/dotnet/fsharp/issues/13194
[<Fact>]
let ``Sig file XML doc fallback works for member whose name contains a single quote`` () =
Expand Down
Loading