Harden AI review quality: subagent dispatch, inline-only output, no wall-of-text#19772
Merged
Conversation
…text
Evidence from 17 AI review audit:
- 53% had zero inline comments (wall-of-text body only)
- 5 reviews were LGTM verdicts buried in avg 1500 chars of prose
- Only 3/17 were inline-focused (ideal)
expert-reviewer.md:
- Wave 0: MUST dispatch independent subagents per dimension via task tool
- Wave 5: empty body for findings (just inline comments), 'LGTM' for approve
- New hard rule: body >10 chars (other than LGTM) is a bug
- Removed 'See inline comments' boilerplate — people have eyes
reviewing-compiler-prs/SKILL.md:
- Replaced aspirational 'Multi-Model Dispatch' with concrete 'Subagent Dispatch'
- Each dimension gets independent background agent with CHECK rules + filtered diffs
- Subagents produce structured {file, line, severity, dimension, issue, suggestion}
- Expert-reviewer consolidates, deduplicates, applies assessment gates
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
✅ No release notes required |
github-actions
Bot
added
the
AI-Tooling-Check-Bypassed
abonie
approved these changes
May 20, 2026
github-project-automation
Bot
moved this from New
to In Progress
in F# Compiler and Tooling
github-project-automation
Bot
moved this from In Progress
to Done
in F# Compiler and Tooling
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Audit of 17 AI reviews showed 53% had zero inline comments — the agent dumps analysis as a wall-of-text review body instead of posting actionable inline comments at file+line.
Changes
expert-reviewer.mdLGTMfor approvereviewing-compiler-prs/SKILL.md{file, line, severity, dimension, issue, suggestion}