Fix FS1182 not reported for unused let functions in class types#19805
Open
T-Gro wants to merge 2 commits into
Open
Fix FS1182 not reported for unused let functions in class types#19805T-Gro wants to merge 2 commits into
T-Gro wants to merge 2 commits into
Conversation
Removed the 'not v.IsCompiledAsTopLevel' guard in the local 'reportIfUnused' helper inside CheckIncrementalClasses.IncrClassReprInfo.ChooseRepresentation. Class-let function bindings are promoted to compiler-generated members, which sets IsCompiledAsTopLevel=true and previously silently suppressed FS1182. The helper is local to class-binding representation choice, so this change cannot introduce module-level false positives. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
❗ Release notes required
Warning No PR link found in some release notes, please consider adding it.
|
github-actions
Bot
added
the
AI-Tooling-Check-Bypassed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix #13849: FS1182 ("unused binding") warning was not reported for unused
letfunction bindings inside class types.Problem
Class-let function bindings are promoted to compiler-generated members, which sets
IsCompiledAsTopLevel=true. ThereportIfUnusedhelper inCheckIncrementalClasses.IncrClassReprInfo.ChooseRepresentationhad anot v.IsCompiledAsTopLevelguard that silently suppressed FS1182 for these bindings.Fix
Removed the
not v.IsCompiledAsTopLevelguard from the localreportIfUnusedhelper. This helper is scoped to class-binding representation choice, so the change cannot introduce module-level false positives.Test
Added test cases in
tests/FSharp.Compiler.ComponentTests/CompilerOptions/fsc/warnon/warnon.fsverifying that FS1182 is correctly emitted for unusedletfunctions in class types.Fixes #13849