Skip to content

Override System.Security.Cryptography.Xml to 10.0.8#19830

Merged
T-Gro merged 2 commits into
mainfrom
dev/tomasgrosup/override-crypto-xml
May 27, 2026
Merged

Override System.Security.Cryptography.Xml to 10.0.8#19830
T-Gro merged 2 commits into
mainfrom
dev/tomasgrosup/override-crypto-xml

Conversation

@T-Gro
Copy link
Copy Markdown
Member

@T-Gro T-Gro commented May 27, 2026

Transitive dependency from Microsoft.Build.Tasks.Core pins System.Security.Cryptography.Xml at 10.0.4. Override to 10.0.8 in FSharp.Build.

@T-Gro T-Gro requested a review from a team as a code owner May 27, 2026 10:36
@T-Gro T-Gro requested a review from abonie May 27, 2026 10:36
@T-Gro T-Gro added AI-Auto-Resolve-Conflicts Opt-in: LabelOps merges main into this PR and resolves conflicts every 3h AI-Auto-Resolve-CI Opt-in: LabelOps triages CI failures on this PR every 3h auto-merge labels May 27, 2026
@T-Gro T-Gro enabled auto-merge (squash) May 27, 2026 10:36
@github-actions
Copy link
Copy Markdown
Contributor

✅ No release notes required

@github-actions github-actions Bot mentioned this pull request May 27, 2026
@github-actions github-actions Bot added the AI-Tooling-Check-Bypassed Tooling check: non-fork PR, not diff-analyzed label May 27, 2026
@T-Gro T-Gro force-pushed the dev/tomasgrosup/override-crypto-xml branch from afd5b61 to 2b10970 Compare May 27, 2026 11:53
@github-project-automation github-project-automation Bot moved this from New to In Progress in F# Compiler and Tooling May 27, 2026
@T-Gro T-Gro force-pushed the dev/tomasgrosup/override-crypto-xml branch from 2b10970 to 37f919c Compare May 27, 2026 13:14
Transitive dependency from Microsoft.Build.Tasks.Core pins
System.Security.Cryptography.Xml at 10.0.4. Add direct reference
in FSharp.Build to override to 10.0.8.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@T-Gro T-Gro force-pushed the dev/tomasgrosup/override-crypto-xml branch from 37f919c to f9ed416 Compare May 27, 2026 13:14
… conflicts

The System.Security.Cryptography.Xml 10.0.8 override pulls transitive
dependencies (Microsoft.Bcl.Cryptography, System.Formats.Asn1) that
conflict with System.ValueTuple on net472 when flowing through
ProjectReference from FSharp.Build to fsc.fsproj.

PrivateAssets="all" prevents the package from flowing to consuming
projects while keeping it available to FSharp.Build at build-task
runtime.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@github-actions
Copy link
Copy Markdown
Contributor

Commit pushed: a1e645f

Generated by LabelOps — PR Maintenance

@github-actions
Copy link
Copy Markdown
Contributor

🤖 LabelOps — CI Fix.

All 3 failed jobs (WindowsCompressedMetadata_Desktop Batch1, EndToEndBuildTests, Build_And_Test_AOT_Windows compressed_metadata) shared the same root cause:

MSB3277 in fsc.fsproj::TargetFramework=net472 — the System.Security.Cryptography.Xml 10.0.8 override pulls transitive dependencies (Microsoft.Bcl.Cryptography, System.Formats.Asn1) that introduce a System.ValueTuple version conflict on net472.

Fix: Added PrivateAssets="all" to the PackageReference. This prevents the package from flowing transitively to consumers (fsc via ProjectReference) while keeping it available to FSharp.Build at build-task runtime.

Generated by LabelOps — PR Maintenance · ● 53.2M ·

@T-Gro T-Gro merged commit 5d50ace into main May 27, 2026
48 checks passed
@T-Gro T-Gro deleted the dev/tomasgrosup/override-crypto-xml branch May 28, 2026 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AI-Auto-Resolve-CI Opt-in: LabelOps triages CI failures on this PR every 3h AI-Auto-Resolve-Conflicts Opt-in: LabelOps merges main into this PR and resolves conflicts every 3h AI-Tooling-Check-Bypassed Tooling check: non-fork PR, not diff-analyzed auto-merge

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants