-
Couldn't load subscription status.
- Fork 833
move FCS to netstandard2.0 and purge old net461 related code #7888
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
We currently still target |
|
I wondered about that. If the timing's not right that's cool, this took like half an hour so it'd be easy to do later. |
|
@auduchinok If you wouldn't mind testing a nupkg of this to see if everything works that'd be good. There may be runtime errors for the net461 target but there may not; unfortunately there's no way to analyze that |
|
Rider 2020.1 EAP2 uses the |
|
Thanks @auduchinok - tentatively, let's see if we can take this in once that build ends up shipping outside of EAP. |
|
linking #8722 |
|
Unfortunately the codebase has diverged a lot. We want to take this in, but only once we can confirm it doesn't hose Rider will we continue with it. I'll close this out for now, since picking this up again will involve merging conflicts that could end up being about the same amount of time spent doing this in the first place. |
|
We've been using the netstandard2.0 build for some time now and with the dependency manager fixes it currently works fine. There are some issues when running on Mono but it's likely we won't be using Mono in 2020.2 even as a fallback runtime anymore. |
|
will close this out in favor of #10135 on account of everything being different now |
This moves FCS to NS2.0 only.
The ProjectCracker, ProjectCrackerTool, and MsBuild.v12 projects have been removed, as those were net461 only. In addition, the FscExe and FsiExe samples have been removed, as they relied on .Net Framework Remoting, which has no nice analog in a .Net Standard/.Net Core world.
The netfx.props were removed as well, because nothing else was using them.