Skip to content

Conversation

@PhilippNaused
Copy link
Contributor

@PhilippNaused PhilippNaused commented Nov 13, 2025

Fixes #658

Fixes recently failing tests (e.g. Run 20251113.1) by updating the test data to reflect that .NET 10 is the most recent LTS version.

Example of failed test output:

Expected _commandResult.StdOut to match regex "\ \ 8.0..\ [(/private)?/tmp/InstallScript-Tests/rv5cjri5.ovx/sdk]" because Matching the command output failed. Pattern: \ \ 8.0..\ [(/private)?/tmp/InstallScript-Tests/rv5cjri5.ovx/sdk]


File Name: /bin/bash
Arguments: -c "/tmp/InstallScript-Tests/rv5cjri5.ovx/dotnet --info"
Exit Code: 0
StdOut:
.NET SDK:
Version:           10.0.100
Commit:            b0f34d51fc
Workload version:  10.0.100-manifests.4c0ca8ba
MSBuild version:   18.0.2+b0f34d51f

@PhilippNaused PhilippNaused marked this pull request as ready for review November 13, 2025 19:39
@PhilippNaused PhilippNaused requested a review from a team as a code owner November 13, 2025 19:40
Copy link
Member

@ellahathaway ellahathaway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@PhilippNaused - thank you for your contributions. Given the title of your PR, are you are willing to fix the other tests? The changes would be similar to 7a00cc2 and 7280f2a

@PhilippNaused
Copy link
Contributor Author

@ellahathaway
I can try to add the missing tests for 10.0 wherever I find tests for 9.0.

7280f2a would be the equivalent of adding tests for .NET 11.0. But those fail when I try them since there isn't a preview build yet.

@ellahathaway
Copy link
Member

7280f2a would be the equivalent of adding tests for .NET 11.0. But those fail when I try them since there isn't a preview build yet.

I think we should consider changing any preview references to 10 added in 7280f2a, such as [InlineData("10.0.100-preview.3.25201.16")] to 10.0 GA version.

@PhilippNaused
Copy link
Contributor Author

I think we should consider changing any preview references to 10 added in 7280f2a, such as [InlineData("10.0.100-preview.3.25201.16")] to 10.0 GA version.

Done.

Copy link
Member

@ellahathaway ellahathaway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

Tests fail since .NET 10 was released to GA

2 participants