Fix 24 duplicate test cases in InstallRuntimeFromChannelTestCases#702
Merged
Conversation
Copilot
AI
changed the title
[WIP] Fix duplicate test cases in runtime install tests
Fix 24 duplicate test cases in InstallRuntimeFromChannelTestCases
Apr 28, 2026
The InstallRuntimeFromChannelTestCases property iterates both _runtimeBranches and _channels, which contain overlapping entries (e.g. 6.0 through 11.0). This produces 24 duplicate test case IDs that xUnit skips with warnings, which is wasteful and the output can be confusing. Fix by using a HashSet to deduplicate test case tuples before yielding them. Additionally, grant execute permissions on eng/common bash scripts for an improved local dev experience. Fixes #701 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
MichaelSimons
force-pushed
the
copilot/fix-duplicate-test-cases
branch
from
5015768 to
7312970
Compare
ellahathaway
approved these changes
Apr 29, 2026
github-project-automation
Bot
moved this from Backlog
to Rollout
in .NET Install Scripts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix 24 duplicate test cases in
InstallRuntimeFromChannelTestCasesthat cause xUnit to skip them with warnings, and grant execute permissions oneng/commonbash scripts.Changes
Deduplicate test cases
InstallRuntimeFromChannelTestCasesiterates both_runtimeBranchesand_channels, which contain overlapping entries (6.0 through 11.0). This produces identical test parameter tuples that xUnit skips with "duplicate ID" warnings — 24 in total across 4 test methods. AHashSetis used to deduplicate before yielding.Shell script permissions
Grant execute permission on all
eng/commonbash scripts andbuild.shfor an improved local dev experience on Unix systems.Fixes #701