Switch release/8.0.1xx builds to -Svc pools#20855
Closed
missymessa wants to merge 1 commit intorelease/8.0.1xxfrom
Closed
Switch release/8.0.1xx builds to -Svc pools#20855missymessa wants to merge 1 commit intorelease/8.0.1xxfrom
missymessa wants to merge 1 commit intorelease/8.0.1xxfrom
Conversation
Hardcode -Svc pool names for servicing branch builds: - NetCore1ESPool-Internal → NetCore1ESPool-Svc-Internal - NetCore1ESPool-Internal-XL → NetCore1ESPool-Internal-Svc-XL - NetCore-Public-XL → NetCore-Public-Svc-XL Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
This PR hardcodes servicing (-Svc) Azure DevOps pool names in key pipeline YAMLs for the release/8.0.1xx servicing branch so builds run on servicing infrastructure rather than R&D pools.
Changes:
- Updated SourceBuild SDL
sourceAnalysisPoolto useNetCore1ESPool-Svc-Internal. - Updated internal pipeline pools in
.vsts-ci.ymlfrom$(DncEngInternalBuildPool)toNetCore1ESPool-Svc-Internal(3 occurrences). - Updated VMR build variables to use servicing XL pool names for public and internal PR scenarios.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/SourceBuild/content/eng/pipelines/sb-ci.yml | Hardcodes SDL source analysis pool to the internal servicing pool. |
| eng/pipelines/templates/variables/vmr-build.yml | Switches default pool variables to servicing XL pools for public and internal PR builds. |
| .vsts-ci.yml | Hardcodes multiple internal pool references to the internal servicing pool. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
Author
|
Closing this PR. Looks like the variable that controls the pool is missing from an Arcade step, so that's the root that needs to be fixed. |
This was referenced Apr 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hardcode -Svc pool names for servicing branch builds to ensure they run on servicing infrastructure instead of R&D pools.
Changes
Context
The \pool-providers.yml\ dynamic expression should auto-select -Svc pools for release branches but is not working in practice. This change hardcodes the correct -Svc pools to match the pattern used in dotnet/arcade PRs #16746, #16747, #16748.