Switch release/8.0.4xx builds to -Svc pools#20856
Switch release/8.0.4xx builds to -Svc pools#20856missymessa wants to merge 1 commit intorelease/8.0.4xxfrom
Conversation
Hardcode -Svc pool names for servicing branch builds: - NetCore1ESPool-Internal → NetCore1ESPool-Svc-Internal - NetCore1ESPool-Internal-XL → NetCore1ESPool-Internal-Svc-XL - NetCore-Public-XL → NetCore-Public-Svc-XL - → NetCore1ESPool-Svc-Internal Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
This PR hardcodes servicing (-Svc) Azure DevOps pool names in key pipeline YAMLs so that release/servicing branch builds run on servicing infrastructure rather than R&D pools.
Changes:
- Update VMR build variable defaults to use
NetCore-Public-Svc-XL,NetCore1ESPool-Internal-Svc-XL, andNetCore1ESPool-Svc-Internal. - Update VMR build stage pool parameters to use
-Svcpool names for internal PR and public legs. - Update
.vsts-ci.ymlto hardcodeNetCore1ESPool-Svc-Internalin several internal pool references.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| eng/pipelines/templates/variables/vmr-build.yml | Hardcodes default pool names to -Svc variants. |
| eng/pipelines/templates/stages/vmr-build.yml | Switches stage pool parameter defaults to -Svc pools. |
| .vsts-ci.yml | Replaces $(DncEngInternalBuildPool) usages with NetCore1ESPool-Svc-Internal. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| - ${{ else }}: | ||
| - name: defaultPoolName | ||
| value: $(DncEngInternalBuildPool) | ||
| value: NetCore1ESPool-Svc-Internal | ||
| - name: poolImage_Linux |
There was a problem hiding this comment.
defaultPoolName is now hardcoded to NetCore1ESPool-Svc-Internal for all internal non-PR builds, bypassing the pool-providers variable that selects -Svc vs non--Svc based on branch/PR target. If this variables template is consumed by non-servicing branches as well, this will route those builds onto servicing infrastructure; consider keeping branch-based selection (or adding an explicit condition) unless the template is guaranteed to be used only for servicing branches.
| sourceAnalysisPool: | ||
| name: $(DncEngInternalBuildPool) | ||
| name: NetCore1ESPool-Svc-Internal | ||
| image: 1es-windows-2022 | ||
| os: windows |
There was a problem hiding this comment.
Pool name is hardcoded to NetCore1ESPool-Svc-Internal here while the pipeline still imports /eng/common/templates-official/variables/pool-providers.yml (which normally selects -Svc vs non--Svc based on branch/PR target). If this YAML is expected to work on non-servicing branches too, consider gating the hardcode on release/servicing branches or using $(DncEngInternalBuildPool) once the underlying selection issue is fixed.
| poolInternalAmd64PR: | ||
| name: NetCore1ESPool-Internal-XL | ||
| name: NetCore1ESPool-Internal-Svc-XL | ||
| demands: ImageOverride -equals Build.Ubuntu.2204.Amd64 |
There was a problem hiding this comment.
Pool name is now hardcoded to the servicing pool (NetCore1ESPool-Internal-Svc-XL). Since this template doesn't gate on branch/target branch, any pipeline run that uses it will always route internal PR builds to servicing infrastructure. If the intent is only to use -Svc pools for servicing/release branches, consider restoring branch-based selection (e.g., via pool-providers logic on Build.SourceBranch / System.PullRequest.TargetBranch) or adding an explicit branch condition here so non-servicing builds don't consume -Svc capacity.
|
Closing this PR. Looks like the variable that controls the pool is missing from an Arcade step, so that's the root that needs to be fixed. |
Hardcode -Svc pool names for servicing branch builds to ensure they run on servicing infrastructure instead of R&D pools.
Changes
Context
The pool-providers.yml dynamic expression should auto-select -Svc pools for release branches but is not working in practice. This change hardcodes the correct -Svc pools to match the pattern used in dotnet/arcade PRs #16746, #16747, #16748.