Skip to content

downgrade some dependencies to .NET 8 versions#3874

Merged
jonsequitur merged 2 commits intodotnet:mainfrom
jonsequitur:downgrade-some-package-versions
Feb 27, 2025
Merged

downgrade some dependencies to .NET 8 versions#3874
jonsequitur merged 2 commits intodotnet:mainfrom
jonsequitur:downgrade-some-package-versions

Conversation

@jonsequitur
Copy link
Copy Markdown
Contributor

@jonsequitur jonsequitur commented Feb 27, 2025

No description provided.

@jonsequitur jonsequitur requested review from colombod, jfleisher and shyamnamboodiripad and removed request for colombod February 27, 2025 20:09
shyamnamboodiripad
shyamnamboodiripad approved these changes Feb 27, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@shyamnamboodiripad shyamnamboodiripad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this PR update all BCL packages that were bumped to 9.* back to 8.* or is it just a subset for now?

shyamnamboodiripad
shyamnamboodiripad reviewed Feb 27, 2025
View reviewed changes
Comment thread Directory.Build.props Outdated
@jonsequitur jonsequitur enabled auto-merge (squash) February 27, 2025 21:00
@jonsequitur
Copy link
Copy Markdown
Contributor Author

jonsequitur commented Feb 27, 2025

Does this PR update all BCL packages that were bumped to 9.* back to 8.* or is it just a subset for now?

It's just a subset, based on issues @jfleisher was having embedding a kernel in VS.

Bumping all versions back would prevent C# 13 from being used in .NET Interactive.

@shyamnamboodiripad
Copy link
Copy Markdown
Contributor

shyamnamboodiripad commented Feb 27, 2025

Does this PR update all BCL packages that were bumped to 9.* back to 8.* or is it just a subset for now?

It's just a subset, based on issues @jfleisher was having embedding a kernel in VS.

Bumping all versions back would prevent C# 13 from being used in .NET Interactive.

Ok hopefully this is the set that matters, and we won't have to peel the onion further😄

@jonsequitur jonsequitur merged commit 1f15de0 into dotnet:main Feb 27, 2025
@jonsequitur jonsequitur added the Area-Build & Infrastructure Relating to this repo's build and infrastructure label Mar 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shyamnamboodiripad shyamnamboodiripad shyamnamboodiripad approved these changes

@jfleisher jfleisher Awaiting requested review from jfleisher

Assignees

No one assigned

Labels

Area-Build & Infrastructure Relating to this repo's build and infrastructure

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jonsequitur @shyamnamboodiripad