[tests] *Actually* test char behavior
#1354
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Context: 90ac202 Commit 90ac202 noted two non-blittable types, System.Boolean and System.Char, and attempted to update the unit tests to mention *both* of them, largely for completeness. Unfortunately, the `CharValue` fields were still boolean, meaning System.Char output wasn't actually tested! Update `tests/generator-Tests` so that `CharValue` is a `char`.
jonathanpeppers
approved these changes
Aug 12, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: 90ac202
Commit 90ac202 noted two non-blittable types, System.Boolean and System.Char, and attempted to update the unit tests to mention both of them, largely for completeness.
Unfortunately, the
CharValuefields were still boolean, meaning System.Char output wasn't actually tested!Update
tests/generator-Testsso thatCharValueis achar.