Skip to content

[tests] *Actually* test char behavior #1354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 12, 2025
Merged

[tests] *Actually* test char behavior #1354

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tests/generator-Tests/expected.ji/NonStaticFields/NonStaticField.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
<field deprecated="not deprecated" final="true" name="Value" static="false" transient="false" type="int" type-generic-aware="int" visibility="public" volatile="false">
</field>
<field deprecated="not deprecated" final="false" name="BooleanValue" static="false" transient="false" type="boolean" type-generic-aware="int" visibility="public" volatile="false" />
<field deprecated="not deprecated" final="false" name="CharValue" static="false" transient="false" type="boolean" type-generic-aware="int" visibility="public" volatile="false" />
<field deprecated="not deprecated" final="false" name="CharValue" static="false" transient="false" type="char" type-generic-aware="int" visibility="public" volatile="false" />
</class>
</package>
</api>
Expand Down
8 changes: 4 additions & 4 deletions tests/generator-Tests/expected.ji/NonStaticFields/Xamarin.Test.SomeObject.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,15 +57,15 @@ public bool BooleanValue {


// Metadata.xml XPath field reference: path="/api/package[@name='xamarin.test']/class[@name='SomeObject']/field[@name='CharValue']"
public bool CharValue {
public char CharValue {
get {
const string __id = "CharValue.Z";
const string __id = "CharValue.C";

var __v = _members.InstanceFields.GetBooleanValue (__id, this);
var __v = _members.InstanceFields.GetCharValue (__id, this);
return __v;
}
set {
const string __id = "CharValue.Z";
const string __id = "CharValue.C";

try {
_members.InstanceFields.SetValue (__id, this, value);
Expand Down
2 changes: 1 addition & 1 deletion tests/generator-Tests/expected.ji/StaticFields/StaticField.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
<field deprecated="not deprecated" final="false" name="Value2" static="true" transient="false" type="int" type-generic-aware="int" visibility="public" volatile="false">
</field>
<field deprecated="not deprecated" final="false" name="BooleanValue" static="true" transient="false" type="boolean" type-generic-aware="int" visibility="public" volatile="false" />
<field deprecated="not deprecated" final="false" name="CharValue" static="true" transient="false" type="boolean" type-generic-aware="int" visibility="public" volatile="false" />
<field deprecated="not deprecated" final="false" name="CharValue" static="true" transient="false" type="char" type-generic-aware="int" visibility="public" volatile="false" />
</class>
</package>
</api>
Expand Down
8 changes: 4 additions & 4 deletions tests/generator-Tests/expected.ji/StaticFields/Xamarin.Test.SomeObject.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,15 +68,15 @@ public static bool BooleanValue {


// Metadata.xml XPath field reference: path="/api/package[@name='xamarin.test']/class[@name='SomeObject']/field[@name='CharValue']"
public static bool CharValue {
public static char CharValue {
get {
const string __id = "CharValue.Z";
const string __id = "CharValue.C";

var __v = _members.StaticFields.GetBooleanValue (__id);
var __v = _members.StaticFields.GetCharValue (__id);
return __v;
}
set {
const string __id = "CharValue.Z";
const string __id = "CharValue.C";

try {
_members.StaticFields.SetValue (__id, value);
Expand Down
8 changes: 4 additions & 4 deletions tests/generator-Tests/expected.xaji/NonStaticFields/Xamarin.Test.SomeObject.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,15 +61,15 @@ public bool BooleanValue {

// Metadata.xml XPath field reference: path="/api/package[@name='xamarin.test']/class[@name='SomeObject']/field[@name='CharValue']"
[Register ("CharValue")]
public bool CharValue {
public char CharValue {
get {
const string __id = "CharValue.Z";
const string __id = "CharValue.C";

var __v = _members.InstanceFields.GetBooleanValue (__id, this);
var __v = _members.InstanceFields.GetCharValue (__id, this);
return __v;
}
set {
const string __id = "CharValue.Z";
const string __id = "CharValue.C";

try {
_members.InstanceFields.SetValue (__id, this, value);
Expand Down
8 changes: 4 additions & 4 deletions tests/generator-Tests/expected.xaji/StaticFields/Xamarin.Test.SomeObject.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,15 +73,15 @@ public static bool BooleanValue {

// Metadata.xml XPath field reference: path="/api/package[@name='xamarin.test']/class[@name='SomeObject']/field[@name='CharValue']"
[Register ("CharValue")]
public static bool CharValue {
public static char CharValue {
get {
const string __id = "CharValue.Z";
const string __id = "CharValue.C";

var __v = _members.StaticFields.GetBooleanValue (__id);
var __v = _members.StaticFields.GetCharValue (__id);
return __v;
}
set {
const string __id = "CharValue.Z";
const string __id = "CharValue.C";

try {
_members.StaticFields.SetValue (__id, value);
Expand Down