Fix UTF-8 JNI lookup tests for Android#1398
Merged
jonathanpeppers merged 1 commit intomainfrom Mar 23, 2026
Merged
Conversation
On Android, JNI FindClass throws ClassNotFoundException (not generic JavaException) and GetMethodID throws NoSuchMethodError. The existing string-based tests in JniTypeTest.cs already use #if __ANDROID__ conditionals for the same reason — apply the same pattern to the new UTF-8 overload tests. Fixes dotnet/android#10993 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Updates UTF-8 JNI lookup tests to account for Android-specific exception types thrown by the runtime, keeping the new ReadOnlySpan<byte> overload test suite passing across supported platforms.
Changes:
- Adjust
FindClassUTF-8 “not found” test to expectJava.Lang.ClassNotFoundExceptionon Android. - Adjust invalid UTF-8 instance method signature test to expect
Java.Lang.NoSuchMethodErroron Android.
Member
Author
|
/azp run dotnet.java-interop |
|
No pipelines are associated with this pull request. |
jonathanpeppers
approved these changes
Mar 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The new UTF-8 overload tests from #1393 fail on Android because
Assert.Throws<JavaException>expects an exact type match, but the Android runtime throws more specific exception types:FindClass→Java.Lang.ClassNotFoundException(not genericJavaException)GetMethodID→Java.Lang.NoSuchMethodError(not genericJavaException)This happens because the UTF-8
FindClassoverload intentionally skips theClass.forNamefallback, so the raw JNI exceptions bubble up directly.Fix
Added
#if __ANDROID__conditionals to expect the Android-specific exception types, matching the existing pattern inJniTypeTest.Ctor_ThrowsIfTypeNotFoundandJniTypeTest.InvalidSignatureThrowsJniException.Fixes dotnet/android#10993