Skip to content

Add controlflowguard support to coredistools#422

Merged
AndyAyersMS merged 3 commits intomainfrom
add-cf-coredistools
Aug 29, 2025
Merged

Add controlflowguard support to coredistools#422
AndyAyersMS merged 3 commits intomainfrom
add-cf-coredistools

Conversation

@agocke
Copy link
Copy Markdown
Member

@agocke agocke commented Aug 28, 2025

No description provided.

Copy link
Copy Markdown
Member

@AndyAyersMS AndyAyersMS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to pass this to the compiler as well?

@agocke
Copy link
Copy Markdown
Member Author

agocke commented Aug 29, 2025

@AndyAyersMS
Copy link
Copy Markdown
Member

cl : command line  warning D9025: overriding '/GS' with '/guard:cf>' [D:\a\1\s\obj\win-arm64\tools\coredistools\coredistools.vcxproj]
  coredistools.cpp
D:\a\1\s\src\coredistools\coredistools.cpp(1,1): error C1083: Cannot open include file: 'guardcfw.h': No such file or directory [D:\a\1\s\obj\win-arm64\tools\coredistools\coredistools.vcxproj]

Odd. Maybe some target-specific includes are needed?

@agocke
Copy link
Copy Markdown
Member Author

agocke commented Aug 29, 2025

I might do that in the pr because I couldn’t figure out an easy way to install the dependencies to build this locally :)

@agocke
Copy link
Copy Markdown
Member Author

agocke commented Aug 29, 2025

Turns out it was just a typo. I think this is read.

@AndyAyersMS AndyAyersMS merged commit 7223347 into main Aug 29, 2025
19 checks passed
@agocke agocke deleted the add-cf-coredistools branch September 3, 2025 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants