Remove null reference exception when no JIT_DASM_ROOT specified.#6
Merged
Merged
Conversation
Change adds a bit of a better error message and fixes a initialization problem when computing the next "tag" when the output directory is empty.
Contributor
Author
|
@AndyAyersMS @BruceForstall Fixes the issue with JIT_DASM_ROOT not specified. |
Contributor
Author
|
Fixes part 1 of issue #1 |
Member
|
I think this does what I expect -- that the tool is usable via command line args even if JIT_DASM_ROOT is not set. To confirm: is it an error if JIT_DASM_ROOT is not set, or is the app now just notifying you...? |
Contributor
Author
|
It is not an error if there is no JIT_DASM_ROOT, the message from the tool is just notification in case the user intends to have defaults via JIT_DASM_ROOT. |
Member
|
Good... changes LGTM. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change adds a bit of a better error message and fixes a initialization problem
when computing the next "tag" when the output directory is empty.