Add try except around command creation/invocation.#9
Merged
Conversation
Adds a guard and error message around commands to make a more graceful experience when a tool isn't on the path.
Contributor
Author
|
@AndyAyersMS - Hardens command creation and adds a more sensible error message. Should be last element of #1. (I'm going to open a separate issue for updating the frameworks due to reconciling the list with the .NETStandard set) |
Contributor
Author
|
@pgavlin take a look? |
| } | ||
| catch (CommandUnknownException e) | ||
| { | ||
| Console.WriteLine("\nError: git command not found! Add git to the environment path.\n", e); |
Use Console.Error.WriteLine where appropraite for error output.
Contributor
Author
|
@pgavlin Added separate commit for switching appropriate output to stderr. |
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a guard and error message around commands to make a more graceful
experience when a tool isn't on the path.