Skip to content

Fixed a grammatical error in windows-instructions#1117

Merged
justinormont merged 1 commit intodotnet:masterfrom
amiteshenoy:patch-2
Oct 2, 2018
Merged

Fixed a grammatical error in windows-instructions#1117
justinormont merged 1 commit intodotnet:masterfrom
amiteshenoy:patch-2

Conversation

@amiteshenoy
Copy link
Contributor

We are excited to review your PR.

So we can do the best job, please check:

  • There's a descriptive title that will make sense to other developers some time from now.
  • There's associated issues. All PR's should have issue(s) associated - unless a trivial self-evident change such as fixing a typo. You can use the format Fixes #nnnn in your description to cause GitHub to automatically close the issue(s) when your PR is merged.
  • Your change description explains what the change does, why you chose your approach, and anything else that reviewers should know.
  • You have included any necessary tests in the same PR.

Copy link
Member

@eerhardt eerhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@justinormont justinormont merged commit eb1c141 into dotnet:master Oct 2, 2018
@ghost ghost locked as resolved and limited conversation to collaborators Mar 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants