WIP End of an era - Delete Microsoft.ML.Legacy and related tests. #1971
Conversation
| thrown = true; | ||
| } | ||
| Assert.True(thrown); | ||
| } |
| @@ -1,62 +0,0 @@ | |||
| <?xml version="1.0" encoding="utf-8"?> | |||
| <doc> | |||
| <members> | |||
There was a problem hiding this comment.
this is still needed. you can swap the references
| namespace Microsoft.ML.Benchmarks | ||
| { | ||
| #pragma warning disable 612, 618 | ||
| public class LegacyPredictionEngineBench |
There was a problem hiding this comment.
LegacyPredictionEngineBench [](start = 17, length = 27)
does this need to get translated to the regular prediction engine?
| module SmokeTest1 = | ||
|
|
||
| type SentimentData() = | ||
| [<LoadColumn(columnIndex = 0); DefaultValue>] |
There was a problem hiding this comment.
[<LoadColumn(columnIndex = 0); DefaultValue> [](start = 7, length = 45)
i think those need to get translated too.
| namespace Microsoft.ML.Tests | ||
| { | ||
| #pragma warning disable 612, 618 | ||
| public class OnnxTests : BaseTestBaseline |
There was a problem hiding this comment.
OnnxTests [](start = 17, length = 9)
are there other ONNX tests? Do those need to migrate?
| using Xunit; | ||
|
|
||
| namespace Microsoft.ML.Scenarios | ||
| { |
There was a problem hiding this comment.
I am not positive those tests have an equivalent through the other API.
I know the Scenarios/PipelineApi folder ones do.
| } | ||
|
|
||
| [Fact] | ||
| public void InitializerCreationTest() |
There was a problem hiding this comment.
Is this test really related to legacy APIs?
|
closing this since #2043 replaces this PR. |
ghost
locked as resolved and limited conversation to collaborators
3 participants
I still need to remove all those baseline files that are no longer used and then document all the tests that may need to be re-written using the new API such as ONNX converter test and FSharp test. In the end I want to compare how much the code coverage has changed between this change and master.
CC: @TomFinley, @sfilipi