Lockdown Microsoft.ML.Onnx public surface#2625
Merged
codemzs merged 8 commits intodotnet:masterfrom Feb 20, 2019
Merged
Conversation
codemzs
requested review from
Ivanidzo4ka,
TomFinley,
jignparm,
shauheen,
wschin,
yaeldekel and
zeahmed
wschin
reviewed
Feb 19, 2019
|
|
||
| // Step 2: Convert ML.NET model to ONNX format and save it as a file. | ||
| var onnxModel = mlContext.Model.ConvertToOnnx(model, data); | ||
| var onnxModel = mlContext.Model.ConvertToOnnxProtobufModel(model, data); |
Contributor
There was a problem hiding this comment.
ConvertToOnnxProtobufModel [](start = 44, length = 26)
Seems ConvertToOnnxProtobuf is better. Model doesn't look like a part of a format's name. #Resolved
Contributor
Member
Author
Contributor
I guess there is no way to have protobuf complier to do this for us, right? If so, please add a note to OnnxML.md so that future maintainers can see how this file got created. In reply to: 465344411 [](ancestors = 465344411,465343652) Refers to: src/Microsoft.ML.OnnxConverter/OnnxMl.cs:14 in 4cd1d45. [](commit_id = 4cd1d45, deletion_comment = False) |
codemzs
force-pushed
the
lockdownonnx
branch
from
4cd1d45 to
d55561c
Compare
Codecov Report
@@ Coverage Diff @@
## master #2625 +/- ##
==========================================
- Coverage 71.53% 71.53% -0.01%
==========================================
Files 800 800
Lines 141846 141847 +1
Branches 16119 16119
==========================================
- Hits 101476 101475 -1
- Misses 35918 35919 +1
- Partials 4452 4453 +1
|
wschin
approved these changes
Feb 20, 2019
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #2273
Reduces public API count from 423 to 1.